1
0
Fork 1

Open QR code images in new tab instead of in modal when JS is disabled #11

Open
opened 1 year ago by SomeGuy · 2 comments
SomeGuy commented 1 year ago
Owner
There is no content yet.
gravel commented 1 year ago
Collaborator

@SomeGuy This can be done by wrapping QR code buttons with <a href="data:image/png,..."></a>.
However, doing so sends the encoding of every QR code twice in the HTML (once in the modal, once in the anchor element), so it may not be good practice.
Options:

  • So be it; send each encoding twice. (Quick)
  • Serve QR codes and bypass this problem by using short, identifier-based links. (Ideal)
  • Store the encoding in anchor elements only to maintain non-JS compatibility. Then, either use JS to fill static or dynamic modals with this encoding. (Not great)
@SomeGuy This can be done by wrapping QR code buttons with `<a href="data:image/png,..."></a>`. However, doing so sends the encoding of every QR code twice in the HTML (once in the modal, once in the anchor element), so it may not be good practice. Options: - So be it; send each encoding twice. (Quick) - Serve QR codes and bypass this problem by using short, identifier-based links. (Ideal) - Store the encoding in anchor elements only to maintain non-JS compatibility. Then, either use JS to fill static or dynamic modals with this encoding. (Not great)
gravel commented 1 year ago
Collaborator

Note that serving QR code invite images (Option 2) should take into account whether the invites are fetched on demand, as that creates a tracking vector.

Note that serving QR code invite images (Option 2) should take into account whether the invites are fetched on demand, as that creates a tracking vector.
This repo is archived. You cannot comment on issues.
No Label
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SomeGuy/sessioncommunities.online#11
Loading…
There is no content yet.