1
0
Fork 1

Follow PSR-12 PHP coding style? #14

Open
opened 1 year ago by SomeGuy · 1 comments
SomeGuy commented 1 year ago
Owner

https://www.php-fig.org/psr/psr-12/

When starting this project I wasn't even aware PHP had a (semi-)official coding style.

Personally, I prefer snake_case for readability, but if we want to attract new contributors, we probably should play by the rules.

https://www.php-fig.org/psr/psr-12/ When starting this project I wasn't even aware PHP had a (semi-)official coding style. Personally, I prefer *snake_case* for readability, but if we want to attract new contributors, we probably should play by the rules.
gravel commented 1 year ago
Collaborator

Steps in my view:

  • Reach a consensus on white-space formatting.
  • Codify it in an .editorconfig file and apply it using editor settings.
  • Properly decompose (refactor) the fetching logic to make it legible.
  • Reach a consenus on casing and apply it to the project.
  • Codify casing in a CONTRIBUTING.md file.
  • Weigh the pros and cons of introducing a developer-only dependency for linting.
  • Reach a consensus on a variation of the PSR-12.
  • Codify it in the linter configuration.

So I'd say we are ways off.

Steps in my view: - Reach a consensus on white-space formatting. - Codify it in an [.editorconfig](https://editorconfig.org/) file and apply it using editor settings. - Properly decompose (refactor) the fetching logic to make it legible. - Reach a consenus on casing and apply it to the project. - Codify casing in a `CONTRIBUTING.md` file. - Weigh the pros and cons of introducing a developer-only dependency for linting. - Reach a consensus on a variation of the PSR-12. - Codify it in the linter configuration. So I'd say we are ways off.
This repo is archived. You cannot comment on issues.
No Label
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SomeGuy/sessioncommunities.online#14
Loading…
There is no content yet.