From 81b4c49702ff76ca890d27a14befc31ed280cfeb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 18 Aug 2020 16:46:51 +0200 Subject: [PATCH] move the "missing -trimpath" test to the slow group (#106) This shouldn't break often, so it doesn't need to be covered by 'go test -short'. Moreover, it's still a relatively expensive step, since we end up reaching package compilation. --- testdata/scripts/basic.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/testdata/scripts/basic.txt b/testdata/scripts/basic.txt index 66f9492..64bc2c2 100644 --- a/testdata/scripts/basic.txt +++ b/testdata/scripts/basic.txt @@ -1,7 +1,3 @@ -# Check that we fail if the user ran with -toolexec but without -trimpath. -! exec go build -a -toolexec=garble main.go -stderr 'should be used alongside -trimpath' - # Check that the simplest use of garble works. Note the lack of a module or GOPRIVATE. garble build main.go exec ./main @@ -31,6 +27,10 @@ stdout 'unknown' [short] stop # checking that the build is reproducible is slow +# Check that we fail if the user ran with -toolexec but without -trimpath. +! exec go build -a -toolexec=garble main.go +stderr 'should be used alongside -trimpath' + # Also check that the binary is reproducible. cp main$exe main_old$exe rm main$exe