diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/disappearingmessages/DisappearingMessages.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/disappearingmessages/DisappearingMessages.kt index 6fa9a2e278..c63c196260 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/disappearingmessages/DisappearingMessages.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/disappearingmessages/DisappearingMessages.kt @@ -58,7 +58,10 @@ class DisappearingMessages @Inject constructor( ) ) } - destructiveButton(if (message.expiresIn == 0L) R.string.dialog_disappearing_messages_follow_setting_confirm else R.string.dialog_disappearing_messages_follow_setting_set) { + destructiveButton( + text = if (message.expiresIn == 0L) R.string.dialog_disappearing_messages_follow_setting_confirm else R.string.dialog_disappearing_messages_follow_setting_set, + contentDescription = if (message.expiresIn == 0L) R.string.AccessibilityId_confirm else R.string.AccessibilityId_set_button + ) { set(message.threadId, message.recipient.address, message.expiryMode) } cancelButton() diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt index 090a7a2d0c..b2a85d5d01 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt @@ -257,13 +257,14 @@ class VisibleMessageView : LinearLayout { binding.expirationTimerView.isGone = true if (message.isOutgoing || disappearing) { - val (iconID, iconColor, textId, contentDescription) = getMessageStatusImage(message) + val (iconID, iconColor, textId) = getMessageStatusImage(message) textId?.let(binding.messageStatusTextView::setText) iconColor?.let(binding.messageStatusTextView::setTextColor) iconID?.let { ContextCompat.getDrawable(context, it) } ?.run { iconColor?.let { mutate().apply { setTint(it) } } ?: this } ?.let(binding.messageStatusImageView::setImageDrawable) - binding.messageStatusImageView.contentDescription = contentDescription + binding.messageStatusTextView.contentDescription = context.getString(R.string.AccessibilityId_message_sent_status) + binding.messageStatusImageView.contentDescription = context.getString(R.string.AccessibilityId_message_sent_status) val lastMessageID = mmsSmsDb.getLastMessageID(message.threadId) val isLastMessage = message.id == lastMessageID @@ -305,48 +306,41 @@ class VisibleMessageView : LinearLayout { data class MessageStatusInfo(@DrawableRes val iconId: Int?, @ColorInt val iconTint: Int?, - @StringRes val messageText: Int?, - val contentDescription: String?) + @StringRes val messageText: Int?) private fun getMessageStatusImage(message: MessageRecord): MessageStatusInfo = when { message.isFailed -> MessageStatusInfo( R.drawable.ic_delivery_status_failed, resources.getColor(R.color.destructive, context.theme), - R.string.delivery_status_failed, - null + R.string.delivery_status_failed ) message.isSyncFailed -> MessageStatusInfo( R.drawable.ic_delivery_status_failed, context.getColor(R.color.accent_orange), - R.string.delivery_status_sync_failed, - null + R.string.delivery_status_sync_failed ) message.isPending -> MessageStatusInfo( R.drawable.ic_delivery_status_sending, - context.getColorFromAttr(R.attr.message_status_color), R.string.delivery_status_sending, - context.getString(R.string.AccessibilityId_message_sent_status_pending) + context.getColorFromAttr(R.attr.message_status_color), R.string.delivery_status_sending ) message.isResyncing -> MessageStatusInfo( R.drawable.ic_delivery_status_sending, - context.getColor(R.color.accent_orange), R.string.delivery_status_syncing, - context.getString(R.string.AccessibilityId_message_sent_status_syncing) + context.getColor(R.color.accent_orange), R.string.delivery_status_syncing ) message.isRead || !message.isOutgoing -> MessageStatusInfo( R.drawable.ic_delivery_status_read, - context.getColorFromAttr(R.attr.message_status_color), R.string.delivery_status_read, - null + context.getColorFromAttr(R.attr.message_status_color), R.string.delivery_status_read ) else -> MessageStatusInfo( R.drawable.ic_delivery_status_sent, context.getColorFromAttr(R.attr.message_status_color), - R.string.delivery_status_sent, - context.getString(R.string.AccessibilityId_message_sent_status_tick) + R.string.delivery_status_sent ) } diff --git a/app/src/main/res/layout/view_control_message.xml b/app/src/main/res/layout/view_control_message.xml index dd43439b04..4ff7b1518f 100644 --- a/app/src/main/res/layout/view_control_message.xml +++ b/app/src/main/res/layout/view_control_message.xml @@ -56,7 +56,8 @@ android:layout_marginTop="4dp" android:textColor="@color/accent_green" android:textSize="@dimen/very_small_font_size" - android:text="Follow Setting" + android:text="@string/MessageRecord_follow_setting" + android:contentDescription="@string/" android:layout_width="match_parent" android:layout_height="wrap_content"/> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 55ff86510d..1edb598e81 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -82,6 +82,7 @@ Call button Settings + Confirm Time selector Accept message request Decline message request @@ -113,9 +114,7 @@ Download media Don\'t download media - Message sent status: Sent - Message sent status pending - Message sent status syncing + Message sent status Message request has been accepted Message body Voice message diff --git a/libsession/src/main/res/values/strings.xml b/libsession/src/main/res/values/strings.xml index 3d587cfbfc..08ef7cf3c7 100644 --- a/libsession/src/main/res/values/strings.xml +++ b/libsession/src/main/res/values/strings.xml @@ -15,6 +15,7 @@ %s called you Called %s Missed call from %s + Follow Setting You disabled disappearing messages. You have turned off disappearing messages. You turned off disappearing messages. Messages you send will no longer disappear.