From 832b343031fc5ba332f2485280b02033c04b9cdc Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Fri, 4 Aug 2017 11:45:49 -0700 Subject: [PATCH] Expiring messages: Add clarifying comment about destroy() ordering FREEBIE --- js/expiring_messages.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/expiring_messages.js b/js/expiring_messages.js index 2421de8d5..3cdf2fbd7 100644 --- a/js/expiring_messages.js +++ b/js/expiring_messages.js @@ -12,6 +12,9 @@ expired.on('add', function(message) { console.log('message', message.get('sent_at'), 'expired'); message.getConversation().trigger('expired', message); + + // We delete after the trigger to allow the conversation time to process + // the expiration before the message is removed from the database. message.destroy(); }); expired.on('reset', checkExpiringMessages);