From b0f9644c144001d20a5d44a3273d61ba726a0e51 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Thu, 28 Sep 2017 11:58:45 -0700 Subject: [PATCH] Add certificate name for windows code-signing (#1513) * Add certificate name for windows code-signing electron-builder supports our extended validation code-signing cert, but only on windows. Our release process must now include a signing step on windows. FREEBIE * AppVeyor Remove certificateSubjectName to disable signing * Move code-signing disable package.json updates above build * AppVeyor: Use temporary holding file for package.json changes --- appveyor.yml | 2 ++ package.json | 1 + 2 files changed, 3 insertions(+) diff --git a/appveyor.yml b/appveyor.yml index 164472c9f..ed578f99d 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -14,6 +14,8 @@ install: build_script: - yarn run icon-gen - node build\grunt.js + - type package.json | findstr /v certificateSubjectName > temp.json + - move temp.json package.json - node_modules\.bin\build --em.environment=%SIGNAL_ENV% --publish=never test_script: diff --git a/package.json b/package.json index 793f7fada..499d3909a 100644 --- a/package.json +++ b/package.json @@ -75,6 +75,7 @@ "win": { "asarUnpack": "node_modules/spellchecker/vendor/hunspell_dictionaries", "artifactName": "${productName}-Setup_${version}.${ext}", + "certificateSubjectName": "Signal", "icon": "build/icons/win/icon.ico", "publish": { "provider": "s3",