From d1da0e581ea6bef8b5e41cbf18cd03cd87582ca9 Mon Sep 17 00:00:00 2001
From: Audric Ackermann <audric@loki.network>
Date: Fri, 29 May 2020 09:39:29 +1000
Subject: [PATCH] test message check for identifier set

---
 ts/test/session/messages/DeviceLinkMessage_test.ts       | 5 +++++
 ts/test/session/messages/DeviceUnlinkMessage_test.ts     | 5 +++++
 ts/test/session/messages/EndSessionMessage_test.ts       | 5 +++++
 ts/test/session/messages/GroupInvitationMessage_test.ts  | 5 +++++
 ts/test/session/messages/ReceiptMessage_test.ts          | 5 +++++
 .../session/messages/SessionEstablishedMessage_test.ts   | 5 +++++
 ts/test/session/messages/SessionResetMessage_test.ts     | 5 +++++
 ts/test/session/messages/TypingMessage_test.ts           | 9 +++++++++
 8 files changed, 44 insertions(+)

diff --git a/ts/test/session/messages/DeviceLinkMessage_test.ts b/ts/test/session/messages/DeviceLinkMessage_test.ts
index b23b1f934..80971e8db 100644
--- a/ts/test/session/messages/DeviceLinkMessage_test.ts
+++ b/ts/test/session/messages/DeviceLinkMessage_test.ts
@@ -90,4 +90,9 @@ describe('DeviceLinkMessage', () => {
         expect(linkRequestMessage.ttl()).to.equal(2 * 60 * 1000);
         expect(linkGrantMessage.ttl()).to.equal(2 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(linkRequestMessage.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(linkRequestMessage.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/DeviceUnlinkMessage_test.ts b/ts/test/session/messages/DeviceUnlinkMessage_test.ts
index 7d37942b4..a3fbceb8c 100644
--- a/ts/test/session/messages/DeviceUnlinkMessage_test.ts
+++ b/ts/test/session/messages/DeviceUnlinkMessage_test.ts
@@ -21,4 +21,9 @@ describe('DeviceUnlinkMessage', () => {
     it('ttl of 4 days', () => {
         expect(message.ttl()).to.equal(4 * 24 * 60 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/EndSessionMessage_test.ts b/ts/test/session/messages/EndSessionMessage_test.ts
index b920a320f..7fbd6f8e6 100644
--- a/ts/test/session/messages/EndSessionMessage_test.ts
+++ b/ts/test/session/messages/EndSessionMessage_test.ts
@@ -30,4 +30,9 @@ describe('EndSessionMessage', () => {
     it('ttl of 4 days', () => {
         expect(message.ttl()).to.equal(4 * 24 * 60 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/GroupInvitationMessage_test.ts b/ts/test/session/messages/GroupInvitationMessage_test.ts
index eda32719b..867779743 100644
--- a/ts/test/session/messages/GroupInvitationMessage_test.ts
+++ b/ts/test/session/messages/GroupInvitationMessage_test.ts
@@ -32,4 +32,9 @@ describe('GroupInvitationMessage', () => {
     it('ttl of 1 day', () => {
         expect(message.ttl()).to.equal(24 * 60 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/ReceiptMessage_test.ts b/ts/test/session/messages/ReceiptMessage_test.ts
index 94b6a0e23..eb59bad0f 100644
--- a/ts/test/session/messages/ReceiptMessage_test.ts
+++ b/ts/test/session/messages/ReceiptMessage_test.ts
@@ -42,4 +42,9 @@ describe('ReceiptMessage', () => {
         expect(readMessage.ttl()).to.equal(24 * 60 * 60 * 1000);
         expect(deliveryMessage.ttl()).to.equal(24 * 60 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(readMessage.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(readMessage.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/SessionEstablishedMessage_test.ts b/ts/test/session/messages/SessionEstablishedMessage_test.ts
index ae422c0f8..6d4c4779f 100644
--- a/ts/test/session/messages/SessionEstablishedMessage_test.ts
+++ b/ts/test/session/messages/SessionEstablishedMessage_test.ts
@@ -21,4 +21,9 @@ describe('SessionEstablishedMessage', () => {
     it('ttl of 5 minutes', () => {
         expect(message.ttl()).to.equal(5 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/SessionResetMessage_test.ts b/ts/test/session/messages/SessionResetMessage_test.ts
index 13a78e988..a352250ae 100644
--- a/ts/test/session/messages/SessionResetMessage_test.ts
+++ b/ts/test/session/messages/SessionResetMessage_test.ts
@@ -29,4 +29,9 @@ describe('SessionResetMessage', () => {
     it('ttl of 4 days', () => {
         expect(message.ttl()).to.equal(4 * 24 * 60 * 60 * 1000);
     });
+
+    it('has an identifier', () => {
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });
diff --git a/ts/test/session/messages/TypingMessage_test.ts b/ts/test/session/messages/TypingMessage_test.ts
index 873145cde..29bccb60f 100644
--- a/ts/test/session/messages/TypingMessage_test.ts
+++ b/ts/test/session/messages/TypingMessage_test.ts
@@ -69,4 +69,13 @@ describe('TypingMessage', () => {
         });
         expect(message.ttl()).to.equal(60 * 1000);
     });
+
+    it('has an identifier', () => {
+        const message = new TypingMessage({
+            timestamp: Date.now(),
+            isTyping: true,
+        });
+        expect(message.identifier).to.not.equal(null,  'identifier cannot be null');
+        expect(message.identifier).to.not.equal(undefined,  'identifier cannot be undefined');
+    });
 });