session-desktop

Commit Graph

Author	SHA1	Message	Date
lilia	20baa795ad	Fixes #198 Squished avatars Refactor all avatar views to use a shared partial, then change it to a background image. Requires allowing unsafe-inline styles in the CSP.	11 years ago
lilia	1321a90667	Rename Whisper.View#attributes Avoid colliding with Backbone.View attributes, which is a list of attrs to set on the html element for a view.	11 years ago
lilia	1bb480f6ea	DRY up a common view pattern Define a Whisper.View base class that automatically parses and renders templates and attributes defined by the subclass. This saves us a good number of lines of code as well as some marginal memory overhead, since we are no longer saving per-instance copies of template strings.	11 years ago

Author

SHA1

Message

Date

lilia

20baa795ad

Fixes #198 Squished avatars

Refactor all avatar views to use a shared partial, then change it to a
background image. Requires allowing unsafe-inline styles in the CSP.

lilia

1321a90667

Rename Whisper.View#attributes

Avoid colliding with Backbone.View attributes, which is a list of attrs
to set on the html element for a view.

lilia

1bb480f6ea

DRY up a common view pattern

Define a Whisper.View base class that automatically parses and renders
templates and attributes defined by the subclass. This saves us a good
number of lines of code as well as some marginal memory overhead, since
we are no longer saving per-instance copies of template strings.

3 Commits (36b1e872143f77afaf63be0a16ef6d655239d6cd)