From 407ec997ab022d6e4e4c07b3714a73e926b0d793 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Thu, 10 May 2018 11:57:30 -0400 Subject: [PATCH] Add comment per CR // FREEBIE --- SignalServiceKit/src/Messages/Interactions/OWSContact.h | 2 ++ SignalServiceKit/src/Messages/Interactions/OWSContact.m | 1 + 2 files changed, 3 insertions(+) diff --git a/SignalServiceKit/src/Messages/Interactions/OWSContact.h b/SignalServiceKit/src/Messages/Interactions/OWSContact.h index 586ffb6a3..eeb4d3304 100644 --- a/SignalServiceKit/src/Messages/Interactions/OWSContact.h +++ b/SignalServiceKit/src/Messages/Interactions/OWSContact.h @@ -162,7 +162,9 @@ NSString *NSStringForContactAddressType(OWSContactAddressType value); #pragma mark - System Contact Conversion +// `contactForSystemContact` does *not* handle avatars. That must be delt with by the caller + (nullable OWSContact *)contactForSystemContact:(CNContact *)systemContact; + + (nullable CNContact *)systemContactForContact:(OWSContact *)contact imageData:(nullable NSData *)imageData; #pragma mark - Proto Serialization diff --git a/SignalServiceKit/src/Messages/Interactions/OWSContact.m b/SignalServiceKit/src/Messages/Interactions/OWSContact.m index 70e9b40fa..6828f640a 100644 --- a/SignalServiceKit/src/Messages/Interactions/OWSContact.m +++ b/SignalServiceKit/src/Messages/Interactions/OWSContact.m @@ -558,6 +558,7 @@ NSString *NSStringForContactAddressType(OWSContactAddressType value) #pragma mark - System Contact Conversion +// `contactForSystemContact` does *not* handle avatars. That must be delt with by the caller + (nullable OWSContact *)contactForSystemContact:(CNContact *)systemContact { if (!systemContact) {