diff --git a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@1x.png b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@1x.png index 17f78166a..c782fbb72 100644 Binary files a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@1x.png and b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@1x.png differ diff --git a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@2x.png b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@2x.png index 48b1a26ca..57e5da9c4 100644 Binary files a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@2x.png and b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@2x.png differ diff --git a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@3x.png b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@3x.png index 429e22425..27b4da3a9 100644 Binary files a/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@3x.png and b/Signal/Images.xcassets/table_ic_notification_sound.imageset/table_ic_notification_sound@3x.png differ diff --git a/Signal/src/ViewControllers/NotificationSettingsViewController.m b/Signal/src/ViewControllers/NotificationSettingsViewController.m index f02e3bbde..df653f7e9 100644 --- a/Signal/src/ViewControllers/NotificationSettingsViewController.m +++ b/Signal/src/ViewControllers/NotificationSettingsViewController.m @@ -51,7 +51,6 @@ } actionBlock:^{ OWSSoundSettingsViewController *vc = [OWSSoundSettingsViewController new]; - vc.soundType = OWSSoundType_Notification; [weakSelf.navigationController pushViewController:vc animated:YES]; }]]; [contents addSection:soundsSection]; diff --git a/Signal/src/ViewControllers/OWSConversationSettingsViewController.m b/Signal/src/ViewControllers/OWSConversationSettingsViewController.m index ea333a0b5..55e4a44f4 100644 --- a/Signal/src/ViewControllers/OWSConversationSettingsViewController.m +++ b/Signal/src/ViewControllers/OWSConversationSettingsViewController.m @@ -512,7 +512,6 @@ NS_ASSUME_NONNULL_BEGIN customRowHeight:45.f actionBlock:^{ OWSSoundSettingsViewController *vc = [OWSSoundSettingsViewController new]; - vc.soundType = OWSSoundType_Notification; vc.thread = weakSelf.thread; [weakSelf.navigationController pushViewController:vc animated:YES]; }]]; diff --git a/Signal/src/ViewControllers/OWSSoundSettingsViewController.h b/Signal/src/ViewControllers/OWSSoundSettingsViewController.h index 7d7ac11e7..27b89e488 100644 --- a/Signal/src/ViewControllers/OWSSoundSettingsViewController.h +++ b/Signal/src/ViewControllers/OWSSoundSettingsViewController.h @@ -6,14 +6,10 @@ NS_ASSUME_NONNULL_BEGIN -typedef NS_ENUM(NSUInteger, OWSSoundType) { OWSSoundType_Notification = 0 }; - @class TSThread; @interface OWSSoundSettingsViewController : OWSTableViewController -@property (nonatomic) OWSSoundType soundType; - // This property is optional. If it is not set, we are // editing the global notification sound. @property (nonatomic, nullable) TSThread *thread; diff --git a/Signal/src/ViewControllers/OWSSoundSettingsViewController.m b/Signal/src/ViewControllers/OWSSoundSettingsViewController.m index 340770211..ce7be75b2 100644 --- a/Signal/src/ViewControllers/OWSSoundSettingsViewController.m +++ b/Signal/src/ViewControllers/OWSSoundSettingsViewController.m @@ -27,14 +27,10 @@ NS_ASSUME_NONNULL_BEGIN { [super viewDidLoad]; - switch (self.soundType) { - case OWSSoundType_Notification: - [self setTitle:NSLocalizedString(@"SETTINGS_ITEM_NOTIFICATION_SOUND", - @"Label for settings view that allows user to change the notification sound.")]; - self.currentSound - = (self.thread ? [OWSSounds notificationSoundForThread:self.thread] : [OWSSounds globalNotificationSound]); - break; - } + [self setTitle:NSLocalizedString(@"SETTINGS_ITEM_NOTIFICATION_SOUND", + @"Label for settings view that allows user to change the notification sound.")]; + self.currentSound + = (self.thread ? [OWSSounds notificationSoundForThread:self.thread] : [OWSSounds globalNotificationSound]); [self updateTableContents]; [self updateNavigationItems]; @@ -74,12 +70,7 @@ NS_ASSUME_NONNULL_BEGIN soundsSection.headerTitle = NSLocalizedString( @"NOTIFICATIONS_SECTION_SOUNDS", @"Label for settings UI that allows user to change the notification sound."); - NSArray *allSounds; - switch (self.soundType) { - case OWSSoundType_Notification: - allSounds = [OWSSounds allNotificationSounds]; - break; - } + NSArray *allSounds = [OWSSounds allNotificationSounds]; for (NSNumber *nsValue in allSounds) { OWSSound sound = (OWSSound)nsValue.intValue; OWSTableItem *item; @@ -131,14 +122,10 @@ NS_ASSUME_NONNULL_BEGIN - (void)saveWasPressed:(id)sender { - switch (self.soundType) { - case OWSSoundType_Notification: - if (self.thread) { - [OWSSounds setNotificationSound:self.currentSound forThread:self.thread]; - } else { - [OWSSounds setGlobalNotificationSound:self.currentSound]; - } - break; + if (self.thread) { + [OWSSounds setNotificationSound:self.currentSound forThread:self.thread]; + } else { + [OWSSounds setGlobalNotificationSound:self.currentSound]; } [self.audioPlayer stop];