From b82aedc3a0cbeb2c17b33944ad44b93b315e4395 Mon Sep 17 00:00:00 2001
From: Michael Kirk <michael.code@endoftheworl.de>
Date: Tue, 11 Jul 2017 18:56:25 -0400
Subject: [PATCH] Assertion failures for unexpected promise state

These don't currently result in failed calls, but we should at least
know about it in debug.

// FREEBIE
---
 Signal/src/call/CallService.swift | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Signal/src/call/CallService.swift b/Signal/src/call/CallService.swift
index 25c931ea1..c782d487b 100644
--- a/Signal/src/call/CallService.swift
+++ b/Signal/src/call/CallService.swift
@@ -682,7 +682,7 @@ protocol CallServiceObserver: class {
 
             peerConnectionClient.addRemoteIceCandidate(RTCIceCandidate(sdp: sdp, sdpMLineIndex: lineIndex, sdpMid: mid))
         }.catch { error in
-            owsFail("\(self.TAG) in \(#function) waitForPeerConnectionClient failed with error: \(error)")
+            Logger.error("\(self.TAG) in \(#function) waitForPeerConnectionClient failed with error: \(error)")
         }.retainUntilComplete()
     }
 
@@ -729,7 +729,7 @@ protocol CallServiceObserver: class {
                 return
             }
         }.catch { error in
-            owsFail("\(self.TAG) in \(#function) waitUntilReadyToSendIceUpdates failed with error: \(error)")
+            Logger.error("\(self.TAG) in \(#function) waitUntilReadyToSendIceUpdates failed with error: \(error)")
         }.retainUntilComplete()
     }
 
@@ -1236,17 +1236,17 @@ protocol CallServiceObserver: class {
         AssertIsOnMainThread()
 
         guard self.readyToSendIceUpdatesPromise == nil else {
-            Logger.error("expected readyToSendIceUpdatesPromise to be nil")
+            owsFail("expected readyToSendIceUpdatesPromise to be nil")
             return
         }
 
         guard self.fulfillReadyToSendIceUpdatesPromise == nil else {
-            Logger.error("expected fulfillReadyToSendIceUpdatesPromise to be nil")
+            owsFail("expected fulfillReadyToSendIceUpdatesPromise to be nil")
             return
         }
 
         guard self.rejectReadyToSendIceUpdatesPromise == nil else {
-            Logger.error("expected rejectReadyToSendIceUpdatesPromise to be nil")
+            owsFail("expected rejectReadyToSendIceUpdatesPromise to be nil")
             return
         }
 
@@ -1279,17 +1279,17 @@ protocol CallServiceObserver: class {
         AssertIsOnMainThread()
 
         guard self.peerConnectionClientPromise == nil else {
-            Logger.error("expected peerConnectionClientPromise to be nil")
+            owsFail("expected peerConnectionClientPromise to be nil")
             return
         }
 
         guard self.fulfillPeerConnectionClientPromise == nil else {
-            Logger.error("expected fulfillPeerConnectionClientPromise to be nil")
+            owsFail("expected fulfillPeerConnectionClientPromise to be nil")
             return
         }
 
         guard self.rejectPeerConnectionClientPromise == nil else {
-            Logger.error("expected rejectPeerConnectionClientPromise to be nil")
+            owsFail("expected rejectPeerConnectionClientPromise to be nil")
             return
         }