From e5c0fa89d67f6d1550a9c62d93607149b93d0442 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Thu, 27 Jul 2017 12:48:46 -0400 Subject: [PATCH] Respond to CR. // FREEBIE --- SignalServiceKit/Utilities/extract_analytics_event_names.py | 3 +++ SignalServiceKit/src/Util/OWSAnalyticsEvents.h | 2 ++ SignalServiceKit/src/Util/OWSAnalyticsEvents.m | 2 ++ 3 files changed, 7 insertions(+) diff --git a/SignalServiceKit/Utilities/extract_analytics_event_names.py b/SignalServiceKit/Utilities/extract_analytics_event_names.py index 027627191..21570db9c 100755 --- a/SignalServiceKit/Utilities/extract_analytics_event_names.py +++ b/SignalServiceKit/Utilities/extract_analytics_event_names.py @@ -10,6 +10,9 @@ import commands import re +# This script is used to extract analytics event names from the codebase, +# and convert them to constants in OWSAnalyticsEvents. + git_repo_path = os.path.abspath(subprocess.check_output(['git', 'rev-parse', '--show-toplevel']).strip()) diff --git a/SignalServiceKit/src/Util/OWSAnalyticsEvents.h b/SignalServiceKit/src/Util/OWSAnalyticsEvents.h index 8e5410d5d..a62e83524 100755 --- a/SignalServiceKit/src/Util/OWSAnalyticsEvents.h +++ b/SignalServiceKit/src/Util/OWSAnalyticsEvents.h @@ -8,6 +8,8 @@ NS_ASSUME_NONNULL_BEGIN - (instancetype)init NS_UNAVAILABLE; +// The code between these markers is code-generated by: +// SignalServiceKit/Utilities/extract_analytics_event_names.py #pragma mark - Code Generation Marker + (NSString *)accountsErrorRegisterPushTokensFailed; diff --git a/SignalServiceKit/src/Util/OWSAnalyticsEvents.m b/SignalServiceKit/src/Util/OWSAnalyticsEvents.m index fbe7f3c70..02800c76c 100755 --- a/SignalServiceKit/src/Util/OWSAnalyticsEvents.m +++ b/SignalServiceKit/src/Util/OWSAnalyticsEvents.m @@ -8,6 +8,8 @@ NS_ASSUME_NONNULL_BEGIN @implementation OWSAnalyticsEvents +// The code between these markers is code-generated by: +// SignalServiceKit/Utilities/extract_analytics_event_names.py #pragma mark - Code Generation Marker + (NSString *)accountsErrorRegisterPushTokensFailed