Commit Graph

152 Commits (1439b1b033d149d2cff2ea5fb03af6e19e1315b2)

Author SHA1 Message Date
Morgan Pretty a32af018a7 Refactored the LintLocalizableStrings script
• Added new 'LintControl' mechanisms to allow for ignoring sections of code
• Added new 'MatchType' mechanisms for excluding unlocalized cases
• Updated the code to explicitly handle localized template strings (both single and multiline)
• Updated the code to process files across multiple threads to improve performance
• Updated the code to use Swift 5.7 regex and store in static variables to prevent reconstruction every time they are used
• Removed the list of individual files which are ignored (now just output a count)
• Fixed an issue where having a localized string on a subsequent line could result in an unlocalized (or incorrectly localized) string not being detected
• Fixed an issue where having multiple strings on a single line could result in an unlocalized string not being detected
• Fixed an issue where zero-width characters would result in the variable count comparison between translations failing
• Fixed a number of localization warnings
12 months ago
Ryan ZHAO 57ca0dad8e make explicit accessibility label for modals and error messages of text input 1 year ago
Ryan ZHAO b2ce98ea83 standardize modal & input error accessibility ids 1 year ago
Morgan Pretty 0f549ae77d Renamed 'ScrollableLabelView' to 'ScrollableLabel' 1 year ago
Morgan Pretty 7bfc533882 Created a ScrollableLabelView component for the ConfirmationModal 1 year ago
Ryan ZHAO 3dc0ed255c fix text got cut off unexpectedly in modals 1 year ago
Ryan ZHAO a749f8d656 further fix on scrollable modal 1 year ago
Ryan ZHAO 37f142f1eb fix an UI issue for confirmation model 1 year ago
Ryan ZHAO f8fb647752 fix some modals 1 year ago
Ryan ZHAO 5881b36384 implement Open URL modal 1 year ago
Morgan Pretty 2bcd8e28ab Merge remote-tracking branch 'upstream/dev' into standardised-strings
# Conflicts:
#	Scripts/LintLocalizableStrings.swift
#	Session.xcodeproj/project.pbxproj
#	Session/Closed Groups/EditClosedGroupVC.swift
#	Session/Conversations/ConversationVC+Interaction.swift
#	Session/Conversations/Message Cells/Content Views/QuoteView.swift
#	Session/Conversations/Settings/ThreadDisappearingMessagesSettingsViewModel.swift
#	Session/Conversations/Settings/ThreadSettingsViewModel.swift
#	Session/Conversations/Views & Modals/ConversationTitleView.swift
#	Session/Home/GlobalSearch/GlobalSearchViewController.swift
#	Session/Media Viewing & Editing/GIFs/GifPickerViewController.swift
#	Session/Media Viewing & Editing/PhotoCaptureViewController.swift
#	Session/Media Viewing & Editing/PhotoLibrary.swift
#	Session/Notifications/UserNotificationsAdaptee.swift
#	Session/Open Groups/JoinOpenGroupVC.swift
#	Session/Settings/NukeDataModal.swift
#	Session/Shared/ScanQRCodeWrapperVC.swift
#	SessionMessagingKit/Database/Models/Attachment.swift
#	SessionMessagingKit/Database/Models/DisappearingMessageConfiguration.swift
#	SessionMessagingKit/Database/Models/RecipientState.swift
#	SessionMessagingKit/Sending & Receiving/Attachments/SignalAttachment.swift
#	SessionShareExtension/ShareNavController.swift
#	SessionShareExtension/ThreadPickerVC.swift
#	SessionUIKit/Components/TopBannerController.swift
#	SessionUtilitiesKit/General/String+Utilities.swift
#	SessionUtilitiesKit/Networking/IPv4.swift
#	SignalUtilitiesKit/Media Viewing & Editing/Attachment Approval/AttachmentApprovalInputAccessoryView.swift
#	SignalUtilitiesKit/Media Viewing & Editing/Attachment Approval/AttachmentApprovalViewController.swift
#	SignalUtilitiesKit/Media Viewing & Editing/Attachment Approval/AttachmentCaptionToolbar.swift
#	SignalUtilitiesKit/Screen Lock/ScreenLock.swift
1 year ago
Morgan Pretty 2032dafc74 Merge remote-tracking branch 'upstream/dev' into feature/swift-package-manager
# Conflicts:
#	SessionMessagingKit/Sending & Receiving/Message Handling/MessageReceiver+ExpirationTimers.swift
#	SessionMessagingKit/Sending & Receiving/MessageReceiver.swift
#	SessionSnodeKit/Networking/SnodeAPI.swift
#	SessionUtilitiesKit/Media/DataSource.h
#	SessionUtilitiesKit/Media/DataSource.m
1 year ago
Morgan Pretty ce01f128f3 Replaced Cocoapods with Swift Package Manager for dependency management 1 year ago
Morgan Pretty da6c407e9f Minor tweaks 1 year ago
Ryan ZHAO 19b4055a2e Merge branch 'onboarding' into standardised-strings 1 year ago
Ryan ZHAO aebb68656b fix an issue where on small screen the error message under text input box won't be fully displayed 1 year ago
Ryan ZHAO ecb1b83a8e upgrade to minimum iOS 15.0 support 1 year ago
Ryan ZHAO 90de873ea0 add and modify strings 1 year ago
Ryan ZHAO 1d01eb91ae Merge branch 'onboarding' into standardised-strings 1 year ago
Ryan ZHAO c342deb94e fix input colour after error occured 1 year ago
Ryan ZHAO f4a979f55f Merge branch 'onboarding' into standardised-strings 1 year ago
Ryan ZHAO 63658f70d7 Merge branch 'dev' into standardised-strings 2 years ago
Ryan ZHAO 54d0f06139 add some general localised strings 2 years ago
Ryan ZHAO 86576e4193 fix a crash on iPad when tapping share in invite a friend screen 2 years ago
Ryan ZHAO de0a3b0ee0 Merge branch 'dev' into onboarding 2 years ago
Ryan ZHAO e235b6059f fix an issue where the keyboard can be covering voice call buttons 2 years ago
Ryan ZHAO 6a04ba5fc2 fix untouched strings 2 years ago
Ryan ZHAO 0ebf0ea365 Merge branch 'dev' into standardised-strings 2 years ago
Ryan ZHAO 72fa1ae52a WIP: add accessibility ids 2 years ago
Ryan ZHAO f5afdae646 Merge branch 'dev' into message-detail-screen 2 years ago
Ryan ZHAO 673170360d Merge branch 'dev' into onboarding 2 years ago
Ryan ZHAO 8f0b6d8202 WIP: Replace strings 2 years ago
Ryan ZHAO f9ef58c9d3 WIP: add strings 2 years ago
Ryan ZHAO a4286212b4 imp: default contact list of global search screen 2 years ago
Ryan ZHAO d25783c4df Merge branch 'dev' into onboarding 2 years ago
Ryan ZHAO 2f740c7065 WIP: refactor global search screen into SwiftUI 2 years ago
Morgan Pretty 661720a988 Merge remote-tracking branch 'upstream/dev' into disappearing-message-redesign
# Conflicts:
#	Session.xcodeproj/project.pbxproj
#	Session/Meta/Translations/ar.lproj/Localizable.strings
#	Session/Meta/Translations/be.lproj/Localizable.strings
#	Session/Meta/Translations/bg.lproj/Localizable.strings
#	Session/Meta/Translations/bn.lproj/Localizable.strings
#	Session/Meta/Translations/cs.lproj/Localizable.strings
#	Session/Meta/Translations/da.lproj/Localizable.strings
#	Session/Meta/Translations/de.lproj/Localizable.strings
#	Session/Meta/Translations/el.lproj/Localizable.strings
#	Session/Meta/Translations/en.lproj/Localizable.strings
#	Session/Meta/Translations/eo.lproj/Localizable.strings
#	Session/Meta/Translations/es-ES.lproj/Localizable.strings
#	Session/Meta/Translations/fa.lproj/Localizable.strings
#	Session/Meta/Translations/fi.lproj/Localizable.strings
#	Session/Meta/Translations/fil.lproj/Localizable.strings
#	Session/Meta/Translations/fr.lproj/Localizable.strings
#	Session/Meta/Translations/hi.lproj/Localizable.strings
#	Session/Meta/Translations/hr.lproj/Localizable.strings
#	Session/Meta/Translations/hu.lproj/Localizable.strings
#	Session/Meta/Translations/id.lproj/Localizable.strings
#	Session/Meta/Translations/it.lproj/Localizable.strings
#	Session/Meta/Translations/ja.lproj/Localizable.strings
#	Session/Meta/Translations/ko.lproj/Localizable.strings
#	Session/Meta/Translations/ku.lproj/Localizable.strings
#	Session/Meta/Translations/lt.lproj/Localizable.strings
#	Session/Meta/Translations/lv.lproj/Localizable.strings
#	Session/Meta/Translations/ne-NP.lproj/Localizable.strings
#	Session/Meta/Translations/nl.lproj/Localizable.strings
#	Session/Meta/Translations/no.lproj/Localizable.strings
#	Session/Meta/Translations/pl.lproj/Localizable.strings
#	Session/Meta/Translations/pt-BR.lproj/Localizable.strings
#	Session/Meta/Translations/pt-PT.lproj/Localizable.strings
#	Session/Meta/Translations/ro.lproj/Localizable.strings
#	Session/Meta/Translations/ru.lproj/Localizable.strings
#	Session/Meta/Translations/si-LK.lproj/Localizable.strings
#	Session/Meta/Translations/sk.lproj/Localizable.strings
#	Session/Meta/Translations/sl.lproj/Localizable.strings
#	Session/Meta/Translations/sv-SE.lproj/Localizable.strings
#	Session/Meta/Translations/th.lproj/Localizable.strings
#	Session/Meta/Translations/tr.lproj/Localizable.strings
#	Session/Meta/Translations/uk.lproj/Localizable.strings
#	Session/Meta/Translations/vi.lproj/Localizable.strings
#	Session/Meta/Translations/zh-CN.lproj/Localizable.strings
#	Session/Meta/Translations/zh-TW.lproj/Localizable.strings
#	SessionMessagingKit/Configuration.swift
#	SessionUtilitiesKit/Database/Storage.swift
2 years ago
Ryan ZHAO ecd8083ebe WIP: refactor global search screen into SwiftUI 2 years ago
Ryan ZHAO 3ea127ab5e imp: customised search bar in SwiftUI 2 years ago
Ryan ZHAO 16b597e35a organize file 2 years ago
Ryan ZHAO 0fc40edb71 update the text input to support multiple lines 2 years ago
Morgan Pretty 3f19c776d9 Fixed a few issues around jumping between messages
Fixed a bug where tapping on quotes could break after loading lots of visible cells
Fixed a bug where a cell which contained both links and a quote would only ever let you interact with the quote
Fixed an issue where message highlight wasn't working when jumping between messages
2 years ago
Ryan ZHAO 16fbffd3d5 fix underline for links 2 years ago
ryanzhao 2a10ab208a clean up and implementation in message info screen 2 years ago
ryanzhao f603b422b0 Merge branch 'dev' into message-detail-screen
# Conflicts:
#	Session/Media Viewing & Editing/MediaInfoVC+MediaPreviewView.swift
#	SignalUtilitiesKit/Media Viewing & Editing/OWSVideoPlayer.swift
2 years ago
Ryan Zhao cf63d6e48f imp: modal of hiding recovery password permanently 2 years ago
Ryan Zhao 45d2964bf1 Merge branch 'dev' into onboarding 2 years ago
ryanzhao f9531a4cc8 polish the recovery password remider 2 years ago
Morgan Pretty a6931bb922 Merge remote-tracking branch 'upstream/dev' into disappearing-message-redesign
# Conflicts:
#	Session.xcodeproj/project.pbxproj
#	Session/Conversations/Settings/ThreadDisappearingMessagesSettingsViewModel.swift
#	Session/Conversations/Settings/ThreadSettingsViewModel.swift
#	Session/Shared/SessionTableViewController.swift
#	Session/Shared/SessionTableViewModel.swift
#	Session/Shared/Types/SessionTableSection.swift
#	SessionTests/Conversations/Settings/ThreadDisappearingMessagesViewModelSpec.swift
#	SessionUIKit/Components/SessionButton.swift
2 years ago
Morgan Pretty 89b38dc2f5
Merge pull request #928 from mpretty-cyro/fix/blocked-contacts-crash
Fixed a crash on the blocked contacts screen and refactoring
2 years ago