Commit Graph

1277 Commits (b36a0061e18ef468bb409d0374c9aa3b87c4fe60)

Author SHA1 Message Date
Matthew Chen 17541a8888 Change conversation bubble colors. 7 years ago
Matthew Chen 01f63792f8 Respond to CR. 7 years ago
Matthew Chen 7cb0158331 Apply UD access verifier. 7 years ago
Matthew Chen 3b06434d4f Split out second web socket. 7 years ago
Matthew Chen c137e95ae5 Move socket manager to hang on SSKEnvironment. 7 years ago
Matthew Chen a697072271 Respond to CR. 7 years ago
Michael Kirk 2b805e4eae Constantize ConversationColorName, map previous incorrect values 7 years ago
Michael Kirk d59e21e7f0 Nothing outside of TSThread should know about legacy colors 7 years ago
Michael Kirk 405cc31a38 Apply new colors to new conversation 7 years ago
Matthew Chen ccb67f49a3 Fix issues in UD send & receive. 7 years ago
Matthew Chen 0b41e5e240 Rework profile fetch to reflect UD changes. 7 years ago
Michael Kirk f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
7 years ago
Matthew Chen 3eb84ed0e0 Move message processing singletons to SSKEnvironment. 7 years ago
Matthew Chen 4ab281346a Respond to CR. 7 years ago
Matthew Chen 95387dd220 Fix rebase breakage. 7 years ago
Matthew Chen 1d40cbfb41 Rework account attributes; persist manual message fetch; add "unrestricted UD" setting. 7 years ago
Matthew Chen 7fd15d2fd9 Add server certificate methods to UD manager. 7 years ago
Matthew Chen 71da312336 Post-SMK ud changes. 7 years ago
Michael Kirk 8faf8668bd lighter sheetview handle for dark theme 7 years ago
Michael Kirk 043b0c8359 swipe to dismiss sheet view 7 years ago
Matthew Chen 24d7a97616 Fix rebase breakage. 7 years ago
Matthew Chen 3738155c81 Fix build breakage from SMK. 7 years ago
Matthew Chen 8ae200ac21 Fix build breakage around SignalCoreKit. 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Michael Kirk 06eae47e09 ConversationViewItem -> protocol 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Matthew Chen b076f14964 Swift exit(). 7 years ago
Matthew Chen 1e82caed03 Remove dark theme feature flag. 7 years ago
Matthew Chen fbeb07d2e4 Fix build break. 7 years ago
Michael Kirk acd042c35a Sort conversation colors 7 years ago
Michael Kirk 4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
7 years ago
Michael Kirk 95a6df6496 Generic SheetViewController 7 years ago
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
7 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 7 years ago
Michael Kirk 3518d37c3e use autorelease pool in migration to avoid accumulating memory 7 years ago
Matthew Chen 2b75c4034d Pull out OWSConversationColor to its own file. 7 years ago
Matthew Chen 5a99cd347f Pull out OWSConversationColor to its own file. 7 years ago
Matthew Chen 43dc362fc7 Fix secondary color within message bubbles. 7 years ago
Matthew Chen 0e5f42defe Use new asset for default contact avatars. 7 years ago
Matthew Chen 857cdf4368 Map the legacy conversation color names. 7 years ago
Matthew Chen ec0206ff01 Adapt text size of default avatars to avatar size. 7 years ago
Matthew Chen 6d14a1b472 Local profile default avatars should use steel background. 7 years ago
Matthew Chen 27488f078a Replace old "default profile avatar" icon with default avatar for local user. 7 years ago
Matthew Chen e4ab360716 Respond to CR. 7 years ago
Matthew Chen 547724b5cf Add inner shadows to profile pics. 7 years ago
Matthew Chen 352777765e Add inner shadows to profile pics. 7 years ago
Matthew Chen ff6feafe8c Update text colors. 7 years ago
Matthew Chen 6715e3d1ad Respond to CR. 7 years ago
Matthew Chen b20cd57383 Rename OWSConversationColor. 7 years ago
Matthew Chen 3adc03fa2c Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 26a2d568de Add "conversation color mode" enum. 7 years ago
Matthew Chen e5150267c2 Rework the conversation color constants. 7 years ago
Matthew Chen da63731447 Respond to CR. 7 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 1c920c6be6 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 2f9eae5caf Respond to CR. 7 years ago
Michael Kirk 04a52980a3 fixup migration
- nested transaction for enumeration
- save when complete
7 years ago
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 7 years ago
Michael Kirk c2f87c738a trivial replace of timestampForSorting -> sortId in some logging 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk 2eb3ec6d0c benchmark migration 7 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
7 years ago
Michael Kirk c27d35f8f2 sort search results by sortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Matthew Chen 7b2dd19fb8 Respond to CR. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 7 years ago
Matthew Chen 6a712366ae Tweak gray 95. 7 years ago
Matthew Chen 922c505559 Respond to CR. 7 years ago
Matthew Chen ef6689410b Design feedback from Myles. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen 3b2c5bfc7b Modify mock environments to register all db views. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Michael Kirk 21e67e9a1d New resolutions for call banner, rename to accommodate multiple X devices.
Only apply work-around to legacy versions where required.
7 years ago
Michael Kirk 3df0e72eda Extract SPK rotation and CreatePreKey operations 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk e7f9598e68 disable dark theme switch for production 7 years ago
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk b447e68597 clarify post-unblock-group copy 7 years ago
Michael Kirk c1b88b5f48 copy cleanup: remove redundant body 7 years ago
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 7 years ago
Michael Kirk 1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
7 years ago
Michael Kirk c0991fce74 enable dark theme for beta 7 years ago
Michael Kirk 7b7da4bc13 add docs to BlockListCache 7 years ago
Michael Kirk fd492f379a Use BlockListCache where possible 7 years ago
Michael Kirk 2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
7 years ago
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
7 years ago
Michael Kirk 28d28cf2b6 remove unused code 7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk 8aba5725cf BlockListViewController v. group blocking 7 years ago
Michael Kirk c6de8c579c WIP: Localizations 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen 3935b019f4 Add base class for tests. 7 years ago
Matthew Chen 3fe7d7f9be Remove more usage of logTag. 7 years ago
Michael Kirk 5bafc7b6d6 Don't allow enabling dark theme in production yet 7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 106ecf2e8e Respond to CR. 7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen 34a05cdb85 Refine image validation. 7 years ago
Matthew Chen 51e8fdcb25 Use small thumbnail when creating quoted reply. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 7 years ago
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk d6f856a626 fixup: Leave theme enabled if ever enabled 7 years ago
Michael Kirk 4e19a79436 Leave theme enabled if ever enabled 7 years ago
Michael Kirk 64dd7c79ed enable dark theme for beta 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen b4539328e1 Log call session description. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 1a92f414eb Revert "Disable dark theme in production."
This reverts commit 472a92a1a3.
7 years ago
Michael Kirk 1d2590fa12 Merge tag '2.29.0.17' 7 years ago
Michael Kirk bc2ba63c21 DRY refactor 7 years ago
Michael Kirk 37738c24c5 Allow menuActions + callBanner
// FREEBIE
7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Matthew Chen 472a92a1a3 Disable dark theme in production. 7 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk 75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen 4971d40c75 Respond to CR. 7 years ago
Matthew Chen 9e21612298 Respond to CR. 7 years ago
Matthew Chen 6dd474d794 Theme quoted replies. 7 years ago
Matthew Chen a92fca5c13 Theme quoted replies. 7 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
7 years ago
Matthew Chen c7ed09ed91 Fix 'can't delete formatting in phone number' issue. 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 22dda476bb Fix QA issues in theme. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk 71cb90b575 Avoid incremental theme-redraws
IMO this feels more impressive
7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
7 years ago
Michael Kirk 1ff443c3ac restore transparent navbar in attachment approval 7 years ago
Michael Kirk ebd2e6d5ac Tweak theme 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 8ecf6884c5 Remove "sending" color for outgoing messages. 7 years ago
Matthew Chen 3fc3425605 Theme search bars. 7 years ago
Matthew Chen 800689d9ff Configure default cells. 7 years ago
Matthew Chen 2c9c028504 Clean up. 7 years ago
Matthew Chen adadf094d4 Enable theme. 7 years ago
Matthew Chen 6dfe36f9b5 Respond to CR. 7 years ago
Matthew Chen 816f02fbab Fix unintentional moves. 7 years ago
Matthew Chen 9c92719ec4 Refine theme. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen acd7d094b1 Refine theme. 7 years ago
Matthew Chen a56a16411f Refine theme. 7 years ago
Matthew Chen a543cd5a4e Refine theme. 7 years ago
Matthew Chen ce4fdd5135 Refine theme. 7 years ago
Matthew Chen d34f83b445 Refine theme. 7 years ago
Matthew Chen 4f8dbf39b5 Refine theme. 7 years ago
Michael Kirk 0620aba3bc Add cancel button 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk e5b3cbd00c Use StoreKit for reviews 7 years ago
Matthew Chen a5ffbdebb3 Remove Obj-c proto parser. 7 years ago
Matthew Chen 06d84860ae Fix rebase breakage. 7 years ago
Matthew Chen 45e782c243 Revamp orphan data cleaner. 7 years ago
Michael Kirk 0bc03b0fd4 Move seed 7 years ago
Matthew Chen 6be3d2e42d Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen dfc39b4a1d Tidy files. 7 years ago
Matthew Chen e6bc37d941 Tidy files. 7 years ago
Matthew Chen 8f55f53329 Tidy files. 7 years ago
Matthew Chen d6cb07cc4a Respond to CR. 7 years ago
Matthew Chen 0f4e846ed7 Tidy profile avatars. 7 years ago
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 7 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 7 years ago
Michael Kirk def8b43daa iOS9/10 fixups 7 years ago
Michael Kirk 78b4df95a5 fixup call banner offsets 7 years ago
Jesse Squires 6dc74ddcaf Fix some project warnings + other fixes
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
7 years ago
Matthew Chen fa8a07abf1 Respond to CR. 7 years ago
Matthew Chen 581347a7fb Refine theme. 7 years ago
Matthew Chen 7759c9ca0f Refine theme. 7 years ago
Matthew Chen f795b12a86 Refine theme. 7 years ago
Michael Kirk 6e1c1a681b Merge tag '2.28.0.12' 7 years ago
Michael Kirk b42f528713 Integrate with new contact discovery endpoint
Also:
* use system cookie parsing
* add AESGCM additional authenticated data parameter

// FREEBIE
7 years ago
Matthew Chen 25a98554b7 Intern JSQMessagesViewController. 7 years ago
Matthew Chen 906d0b01a4 Fix build break. 7 years ago
Matthew Chen 819c2b1ceb Remove Twisted Oak. 7 years ago
Michael Kirk 3d6b8e2bb5 hide navbar blur layer in attachment approval, which has a clear navbar 7 years ago
Matthew Chen 2b1f928770 Respond to CR. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Matthew Chen 8862f9a531 Refine views. 7 years ago
Matthew Chen fcbf8d4dc2 Refine views. 7 years ago
Matthew Chen 9f9e0965d5 Refine table views. 7 years ago
Michael Kirk ab1190222b Fix overzealous failure when user has no Signal contacts
// FREEBIE
7 years ago
Matthew Chen 460f7344ad Remote attestation. 7 years ago
Matthew Chen 39c7fd9f15 Respond to CR. 7 years ago
Matthew Chen 3c3742aae9 Clean up ahead of PR. 7 years ago
Matthew Chen bf1642052a Fix nullability. 7 years ago
Matthew Chen 03e5d2973b Delta contact intersections. 7 years ago
Matthew Chen d14f764b50 Streamline SignalRecipient. 7 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 7 years ago
Matthew Chen 0c453c8d57 Fix content insets. 7 years ago
Michael Kirk 11fc674ef4 Avoid blur as overly-tall navigation bar lingers after dismissal.
Use the precise status bar height.
7 years ago
Michael Kirk 7a5f5476db rename to avoid confusion 7 years ago
Michael Kirk 06b4584e02 move fix to OWSViewController 7 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 7 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
7 years ago
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
7 years ago
Matthew Chen c3b02522ca Fix oversize accessory view. 7 years ago
Matthew Chen 3a3fb0e41b Fix oversize accessory view. 7 years ago
Michael Kirk 1a2428a4b0 CR: leave some wiggle room on max window height. 7 years ago
Michael Kirk bdc8181cbc hide menu view controller when resigning active
// FREEBIE
7 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
7 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
7 years ago
Michael Kirk 3a157d9df6 window level on iOS11
// FREEBIE
7 years ago
Michael Kirk 0c4cae133b milestone: route one real action (copy text) 7 years ago
Michael Kirk bb6722ea42 animate in/out 7 years ago
Michael Kirk ceeddbc67b localize, proper action height 7 years ago
Michael Kirk adfaeaa8e1 round top corners 7 years ago
Michael Kirk 57400e1ecb WIP: ActionView 7 years ago
Michael Kirk 635c0275db stop observing db notifications while message actions are presented
This let's new messages appear after the message actions are dismissed without
complicating scroll state.
7 years ago
Michael Kirk 6275a2f102 Highlight focused view 7 years ago
Michael Kirk 22fada2457 don't dismiss keyboard when presenting actions 7 years ago
Michael Kirk aa98963fd9 Abandonded: separate window pattern
Hiding the old window, caused keyboard to resign first responder.
7 years ago
Michael Kirk 6037a440c9 wire up window mgmt 7 years ago
Michael Kirk a2c67bb96b Enhance navbar blur, match input toolbar blur
// FREEBIE
7 years ago
Matthew Chen 3729943cd3 Fix production build breakage. 7 years ago
Matthew Chen b2f42adb86 Respond to CR. 7 years ago
Matthew Chen f6eb8dfe72 Refine app settings view. 7 years ago
Matthew Chen 20d1d11259 Refine home view. 7 years ago
Matthew Chen 8287076499 More design tweaks. 7 years ago
Matthew Chen 0c420ed28a Tweak appearance. 7 years ago
Matthew Chen 750b935122 Tweak appearance. 7 years ago
Matthew Chen 376e2cc1db Respond to CR. 7 years ago
Matthew Chen 35f058c46a Rework unread indicators. 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
7 years ago
Michael Kirk 92705490a0 No write transaction needed for syncing colors
// FREEBIE
7 years ago
Michael Kirk 4d3d5d98e1 Sync colors with contacts 7 years ago
Michael Kirk c8b4e879e7 CR: remove unused font 7 years ago
Michael Kirk f22cb48f85 date break font/color to spec
// FREEBIE
7 years ago
Michael Kirk 28abf426f1 White status bar for call screen
Transition to VC controlled status bar style.
7 years ago
Michael Kirk 998c2f392c CR: inline per code review 7 years ago
Michael Kirk 834021fe39 tweak selected color for homeview cells 7 years ago
Michael Kirk 10ac7be03a prefer localizedUppercaseString for user facing text
// FREEBIE
7 years ago
Michael Kirk 76745bee5b failed background color to spec 7 years ago
Michael Kirk b0978abd01 use points not pixels when determining how short a device is 7 years ago
Matthew Chen 03d393553a Tweak home view cells. 7 years ago
Matthew Chen b92fc89986 Retweak date and unread messages breaks. 7 years ago
Matthew Chen 712d6d89e1 Tweak relative timestamps. 7 years ago
Matthew Chen a28a5251f6 Respond to CR. 7 years ago
Matthew Chen 4893b01907 Retweak colors. 7 years ago
Matthew Chen 4b448ed018 Retweak colors. 7 years ago
Matthew Chen bbd65d6433 Retweak colors. 7 years ago
Matthew Chen 929615ab0c Tweak sender avatar sizes. 7 years ago
Matthew Chen 57c79fd797 Respond to CR. 7 years ago
Matthew Chen 1a9a5016fe Tweak calls. 7 years ago
Michael Kirk b301dba4ba cell height to spec 7 years ago
Matthew Chen c460ff2945 Fix contact cell layout. 7 years ago
Matthew Chen 01cc206e8e Tweak styling of phone number + profile name. 7 years ago
Matthew Chen 5b5ef7e0bf Respond to CR. 7 years ago
Matthew Chen dd078b106f Tweak message send failed indicator. 7 years ago
Matthew Chen 19699fd45f Tweak message send failed indicator. 7 years ago
Michael Kirk 0f34f76611 Merge tag '2.27.1.1' 7 years ago
Michael Kirk b47062831f Don't block "register" button on iPad registration
On short devices, add a toolbar with a "dismiss" button to the number pad.
7 years ago
Michael Kirk 83d3f17d44 remove unused code, add comment 7 years ago
Michael Kirk 2b588017f3 round attachment approval toolbar 7 years ago
Matthew Chen 05b1b37eab Respond to CR. 7 years ago
Matthew Chen 92a9796e9e Respond to CR. 7 years ago
Matthew Chen 1412998b4a Rework isRTL. 7 years ago
Matthew Chen 39eac9129b Respond to CR. 7 years ago
Matthew Chen 32f33f6d12 Tweak sender names. 7 years ago
Michael Kirk 4f94d5c5a9 default value 7 years ago
Michael Kirk 5719aba91a separate icon vs. title color for toolbars 7 years ago
Michael Kirk 126d41e542 Fixup "scroll down" button so it doesn't fall behind toolbar 7 years ago
Michael Kirk ee898829a1 fixup white nav 7 years ago
Michael Kirk 767f06b09f fixup status bar 7 years ago
Michael Kirk 104e63ded9 remove appearance juggling 7 years ago
Michael Kirk f8abe32ae9 more styling to new nav colors 7 years ago
Michael Kirk 5d6a988955 WIP navbar 7 years ago
Michael Kirk de56eb9d6b Proper color for compose screen avatars
ConversationCell#thread is nullable

// FREEBIE
7 years ago
Michael Kirk 16df4f589e conversation colors
// FREEBIE
7 years ago
Matthew Chen 24c4c4c098 Respond to CR. 7 years ago
Matthew Chen d2f2e1cb22 Respond to CR. 7 years ago
Matthew Chen 87380894ba Tweak message cells. 7 years ago
Matthew Chen 17d4ccc489 Disable compact text layout. 7 years ago
Matthew Chen 35dc348551 Move conversation style. 7 years ago
Matthew Chen af4eb39a2d Respond to CR. 7 years ago
Matthew Chen a34719ce69 Tweak color palette. 7 years ago
Matthew Chen f2153f888b Tweak color palette. 7 years ago
Matthew Chen cbc80abff1 Tweak color palette. 7 years ago
Matthew Chen ce9a9ec925 Tweak color palette. 7 years ago
Matthew Chen 8943669d88 Tweak colors. 7 years ago
Matthew Chen 7634e3a44d Respond to CR. 7 years ago
Matthew Chen 2b457c6499 Tweak contact shares. 7 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 7 years ago
Michael Kirk 803a58f33a avoid assert
// FREEBIE
7 years ago
Michael Kirk 9f06163b76 Fix contacts reminder view
We had a guard that prevented 'called at least once' from ever getting set when contacts access was disabled.

// FREEBIE
7 years ago
Michael Kirk cde1c3fb7c Fix: iOS10 was not respecting margins with our homebrew pin method
// FREEBIE
7 years ago
Matthew Chen 8cb057c23f Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen c8d0a80032 Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 2ecbf1bb65 Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 1a57fe631c Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 0df71e22a5 Fix message detail view. 7 years ago
Matthew Chen 71c63d9fce Remove obsolete assert. 7 years ago
Matthew Chen b75f4596aa Remove obsolete assert. 7 years ago
Michael Kirk cc1bde34cd Inform iPad users upon registration
// FREEBIE
7 years ago
Matthew Chen fbbb9276b9 Respond to CR. 7 years ago
Matthew Chen 63b6276c25 Clear LRUCache in background. 7 years ago
Matthew Chen 87ea1dcae1 Clean up ahead of PR. 7 years ago
Matthew Chen 08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 7 years ago
Matthew Chen b9e2963f47 Don't cache CNContact. 7 years ago
Matthew Chen 83f11ad79b Don't cache CNContact. 7 years ago
Matthew Chen 12295bd8c5 Don't cache CNContact. 7 years ago
Matthew Chen 20b1a2606e Outage detection. 7 years ago
Matthew Chen 776b5abed1 Handle edge cases around unread indicator & contact offers. 7 years ago
Matthew Chen 647d80d79d Unify the cell and avatar sizes. 7 years ago
Matthew Chen 1acf51ea5c Unify the cell and avatar sizes. 7 years ago
Matthew Chen 261719e53b Unify the cell and avatar sizes. 7 years ago
Matthew Chen 40e5bcc23f Respond to CR. 7 years ago
Matthew Chen dd49c6225f Auto-size contact cells everywhere. 7 years ago
Matthew Chen a51e9b78b0 Improve search query construction. 7 years ago
Matthew Chen 95ac17bb7e Merge tag '2.26.0.24' 7 years ago
Michael Kirk 0dec029a69 Don't mark as read when callscreen is active
// FREEBIE
7 years ago
Matthew Chen c8fee4efa7 Add swift logging to SSK. 7 years ago
Matthew Chen 44b23d44fd Respond to CR. 7 years ago
Matthew Chen 99677899b1 Respond to CR. 7 years ago
Matthew Chen f0c1805de9 Strip snippet formatting. 7 years ago
Matthew Chen 9639d3cbae Clean up ahead of PR. 7 years ago
Matthew Chen 3f9f2abcd8 Style the search results. 7 years ago
Matthew Chen f4a559156c Style the search results. 7 years ago
Matthew Chen 646073c92d Check contacts access when notified of contacts changes. 7 years ago
Matthew Chen ebc5356a9f Respond to CR. 7 years ago
Matthew Chen 758913f959 Respond to CR. 7 years ago
Matthew Chen 4abd3f58cd Order the search results. 7 years ago
Matthew Chen 37d3dfdfb6 Merge tag '2.26.0.23' 7 years ago
Matthew Chen 8164b893ad Respond to CR. 7 years ago
Matthew Chen 999e8c8e31 Respond to CR. 7 years ago
Matthew Chen 13e9f11b4e Open message search results. 7 years ago
Matthew Chen 27b6a5e5bb Open message search results. 7 years ago
Michael Kirk 72e4de0950 Fix unresponsive interface after swipe on root VC
Don't start interactive pop gesture for root VC

// FREEBIE
7 years ago
Michael Kirk 549342c702 Show empty results text
// FREEBIE
7 years ago
Michael Kirk ecdaad06ff Handle no results
In line with other messaging apps, we intentionally don't show a "No Results"
cell. We simply don't display any cells. Though we could easily modify this in
the future.

// FREEBIE
7 years ago
Michael Kirk fff8474150 adapt to rebase conflicts 7 years ago
Michael Kirk f415827da6 Contact search results
// FREEBIE
7 years ago
Michael Kirk b3705196b3 remove unused code/comments 7 years ago
Michael Kirk 21788f5f93 Avatar, label fonts, resignFirstResponder on scroll
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[x] group thread est: actual:
      -[x] group name actual: e.25
      -[x] group member name: e.25
      -[x] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[x] messages e1
      -[x] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[x] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] No Results page
7 years ago
Michael Kirk 3a03c4f74c WIP: message indexing 7 years ago
Michael Kirk f360bcfd35 Less confusing class names
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk a9e2834d9f WIP: FTS - rudimentary show results
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk ffea3a020f WIP: FTS - wired up Search VC
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
7 years ago
Michael Kirk 429af7854a WIP: Full Text Search
-[ ] indexes
  -[x] results: Contacts / Conversations / Messages
  -[ ] group thread
    -[x] group name
    -[ ] group member name
    -[ ] group member number
  -[ ] contact thread
    -[ ] name
    -[ ] number
  -[ ] messages
    -[ ] content
- [ ] show search results: Contact / Conversation / Messages
- [ ] tapping thread search result takes you to conversation
- [ ] tapping message search result takes you to message
- [ ] show snippet text for matched message
- [ ] highlight matched text in thread
- [ ] go to next search result in thread
7 years ago
Matthew Chen 19c9e226fb Respond to CR. 7 years ago
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 7 years ago
Matthew Chen 6579857a42 Respond to CR. 7 years ago
Matthew Chen 6f0c1a975b Fix build warnings. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Matthew Chen 40729dbdd2 Use background task while downloading profile avatar. 7 years ago
Óscar Morales Vivó 69b5272547 More code review polish. 7 years ago
Óscar Morales Vivó 4b98352a38 Changes suggested by code review. Added iPhone 4 screen size to iPhoneX test so Signal doesn't blow up in iPad's iPhone compatibility mode. 7 years ago
Matthew Chen fefc9843b1 Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen 812210a63c Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen 40879461b0 Suppress animations in nav bar around call window. 7 years ago
Matthew Chen 4342b04bd3 Include response data in 'request over websocket' failures. 7 years ago
Matthew Chen 5e166c238f Respond to CR. 7 years ago
Matthew Chen 01cf2fc1bd Clear the contacts cache if access to the system contacts is revoked. 7 years ago
Matthew Chen f63d25a172 Migrate to Swift 4. 7 years ago
Matthew Chen 4d8c764789 Migrate to Swift 4. 7 years ago
Matthew Chen 77b72b6b06 Migrate to Swift 4. 7 years ago
Matthew Chen da5ae63bbc Migrate to Swift 4. 7 years ago
Matthew Chen 28e26e1f75 Migrate to Swift 4. 7 years ago
Matthew Chen 916d55c55d Migrate to Swift 4. 7 years ago
Matthew Chen 28f7142a59 Auto-migration to Swift 4. 7 years ago
Matthew Chen 4d498563e7 Unify the socket manager's 'can send requests' logic. 7 years ago
Matthew Chen c71081c875 Respond to CR. 7 years ago
Matthew Chen bbf7ee451d Limit the scope of the 'incomplete contacts fetch' fix. 7 years ago
Matthew Chen 21b54bee4f Fix breakage from recents changes in share extension. 7 years ago
Matthew Chen fbd03a3fdc Apply design for call view back button. 7 years ago
Michael Kirk fc34a0643c CR: annotate device constants
// FREEBIE
7 years ago
Michael Kirk 36ee6af621 respond to CR 7 years ago
Michael Kirk 20424d9a7e remove debug code, reorder for clarity
// FREEBIE
7 years ago
Michael Kirk fe62a6ac92 CNContactController needs to be presented in a navcontroller with a
translucent navbar.

In cases where we were presenting modally, we can easily modify the
modal to have a translucent navbar.

In the one place we were pushing onto the SignalsNavigationController,
rather than modifying the SNC.isTranslucent and having to clean it up,
I've opted to convert to a modal presentation.

// FREEBIE
7 years ago
Michael Kirk 2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
7 years ago
Michael Kirk 4f80100234 Tapping on status bar returns to call
We want to render the return-to-call banner behind the status bar, so
the user can see the system clock, etc.

But normally, doing so would mean we wouldn't receive touches in the top
20px of the screen.

// FREEBIE
7 years ago
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
7 years ago
Michael Kirk 3383c5e80c Fixup for iPhoneX
// FREEBIE
7 years ago
Michael Kirk 778e11c2c3 cleanup ahead of PR
// FREEBIE
7 years ago
Michael Kirk 7ad5f15448 Restore cancleable back gesture for those VC's that use it
// FREEBIE
7 years ago
Michael Kirk 49c652ad14 Comment cleanup
// FREEBIE
7 years ago
Michael Kirk 1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
7 years ago
Michael Kirk 319a6ff765 fixup behavior on iOS10 7 years ago
Michael Kirk 6c7af671bc call banner above status bar for now 7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
7 years ago
Matthew Chen bb19505c6a Make profile gets over websocket. 7 years ago
Matthew Chen e2d9c1187a Fix "group avatar doesn't update after local change." 7 years ago
Michael Kirk b1e06217b2 Consistently lower-case contact field headers
// FREEBIE
7 years ago
Matthew Chen 0620cb60df Normalize image colorspace. 7 years ago
Michael Kirk 2098ec570b Contact picker uses profile pic, when available.
// FREEBIE
7 years ago
Michael Kirk f2750d18c6 Don't send empty contact card with just avatar
// FREEBIE
7 years ago
Matthew Chen db1c8fd9f3 Respond to CR. 7 years ago
Matthew Chen f436fc19c2 Make contact share "bubble/card" reflect share contents. 7 years ago
Matthew Chen 2edabdbba4 Sort group members. 7 years ago
Matthew Chen 152e1d7983 Respond to CR. 7 years ago
Matthew Chen ca09d00e2e Use signal id as avatar color seed if possible. 7 years ago
Matthew Chen edabe50678 Respond to CR. 7 years ago
Matthew Chen a26cba3de1 Don't show screen block until app is ready. 7 years ago
Matthew Chen 0b488f1a65 Use case-insensitive comparison when sorting contacts. 7 years ago
Matthew Chen 73206c08ad Respond to CR. 7 years ago
Matthew Chen b62d6900da Fix crash converting images in SAE. 7 years ago
Matthew Chen ccc64e62bf Fix l10n strings. 7 years ago
Michael Kirk 2cc3eabdb8 quote reply to contact share (no avatar)
// FREEBIE
7 years ago
Michael Kirk d1c33921ba Show avatar in contact approval view
// FREEBIE
7 years ago
Matthew Chen 6460493669 Surface organization name in contact view. 7 years ago
Matthew Chen aa7cc4633a Rework contact names. 7 years ago
Michael Kirk a16040f19f Fix avatar sending in SAE
// FREEBIE
7 years ago
Michael Kirk adabf02732 Fix contact sharing (Avatar TODO)
// FREEBIE
7 years ago
Michael Kirk c15fea4eca merge avatar with existing
// FREEBIE
7 years ago
Michael Kirk bf37f41164 Move CNContact logic into our system contact adapter
// FREEBIE
7 years ago
Michael Kirk 0c469764f1 re-use contact picker for "add to existing"
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
7 years ago
Michael Kirk b1f3324514 cleanup contact syncing
It's largely a redundant check anyway, but the previous typo was a
no-op.

// FREEBIE
7 years ago
Matthew Chen 3bb9e922d7 Surface contact share errors to user. 7 years ago
Matthew Chen 4079cdb600 Apply more contact share assets. 7 years ago
Matthew Chen 0b8d9991ef Respond to CR. 7 years ago
Matthew Chen f77731eb7a Fix h margins in "edit contact share name" view. 7 years ago