Dark Theme #40

Addresses #39.

WIP commentary:

a) I'm not a fan of a while loop checking for file changes. This can be more elegantly solved with inotify.

WIP commentary: a) I'm not a fan of a `while` loop checking for file changes. This can be more elegantly solved with `inotify`.

@SomeGuy

a) The while loop is a necessary and recommended way for executing with entr. It does not actually spam the command: entr -d blocks and re-runs the command on file changes until a change in the scanned directories' contents. As entr returns 1 in such an event, we simply want to scan all the files again. If the user wants to interrupt make watch and presses ^C, entr returns with a 0 and the exit clause is triggered to stop the loop. Currently, I don't see it necessary to introduce inotify as a dev dependency.

@SomeGuy a) The while loop is a necessary and recommended way for executing with `entr`. It does not actually spam the command: `entr -d` blocks and re-runs the command on file changes until a change in the scanned directories' contents. As `entr` returns 1 in such an event, we simply want to scan all the files again. If the user wants to interrupt `make watch` and presses `^C`, entr returns with a 0 and the `exit` clause is triggered to stop the loop. Currently, I don't see it necessary to introduce `inotify` as a dev dependency.

I wasn't aware inotify-tools weren't default for most distros. In fact it's not even installed on the machine I'm writing this on. So I agree with you, introducing an additional dependency is redundant here.
I also wasn't aware of the exact workings of your command, but your explanation sounds plausible.

Regarding the theme:

a) Is there anything we can do to style the QR modals?

b) I find the transition between the themes to take a bit long to be frank.

c) instructions.html is unaffected by the theme switch. Is that intentional?

I wasn't aware `inotify-tools` weren't default for most distros. In fact it's not even installed on the machine I'm writing this on. So I agree with you, introducing an additional dependency is redundant here. I also wasn't aware of the exact workings of your command, but your explanation sounds plausible. Regarding the theme: ![image](/attachments/67fb4ba9-d22f-4b4c-89dc-49b3adf32fb1) a) Is there anything we can do to style the QR modals? b) I find the transition between the themes to take a bit long to be frank. c) `instructions.html` is unaffected by the theme switch. Is that intentional?

image.png

162 KiB

a) Yes, modal theme fixed locally.

b) The transition is slow to be gentle to one's eyes at night.

c) It would require having a similar theme setup in the instruction page and synchronizing the two using JavaScript and localStorage. With dark theme being a good default and the instructions page being secondary, this is low priority.

a) Yes, modal theme fixed locally. b) The transition is slow to be gentle to one's eyes at night. c) It would require having a similar theme setup in the instruction page and synchronizing the two using JavaScript and localStorage. With dark theme being a good default and the instructions page being secondary, this is low priority.

Labels Milestones

Dark Theme #40