Make default group avatar icon actually work.

src/org/thoughtcrime/securesms/contacts/ContactPhotoFactory.java

@@ -19,8 +19,11 @@ import java.util.Map;
 public class ContactPhotoFactory {
 
   private static final Object defaultPhotoLock      = new Object();
+  private static final Object defaultGroupPhotoLock = new Object();
 
   private static Bitmap defaultContactPhoto;
+  private static Bitmap defaultGroupContactPhoto;
+
   private static final Map<Uri,Bitmap> localUserContactPhotoCache =
       Collections.synchronizedMap(new LRUCache<Uri,Bitmap>(2));
 
@@ -40,11 +43,11 @@ public class ContactPhotoFactory {
   }
 
   public static Bitmap getDefaultGroupPhoto(Context context) {
-    synchronized (defaultPhotoLock) {
-      if (defaultContactPhoto == null)
-        defaultContactPhoto =  BitmapFactory.decodeResource(context.getResources(),
+    synchronized (defaultGroupPhotoLock) {
+      if (defaultGroupContactPhoto == null)
+        defaultGroupContactPhoto =  BitmapFactory.decodeResource(context.getResources(),
                                                                  R.drawable.ic_group_photo);
-      return defaultContactPhoto;
+      return defaultGroupContactPhoto;
     }
   }
 

src/org/thoughtcrime/securesms/recipients/RecipientProvider.java

@@ -151,7 +151,7 @@ public class RecipientProvider {
         byte[] avatarBytes = record.getAvatar();
         Bitmap avatar;
 
-        if (avatarBytes == null) avatar = ContactPhotoFactory.getDefaultContactPhoto(context);
+        if (avatarBytes == null) avatar = ContactPhotoFactory.getDefaultGroupPhoto(context);
         else                     avatar = BitmapFactory.decodeByteArray(avatarBytes, 0, avatarBytes.length);
 
         return new RecipientDetails(record.getTitle(), null, avatar);