Merge pull request #490 from BeaudanBrown/incoming-public

Fix duplicate detection for sent messages in public chat

js/background.js

@@ -1303,15 +1303,17 @@
       const descriptorId = await textsecure.MessageReceiver.arrayBufferToString(
         messageDescriptor.id
       );
+      let message;
       if (
         messageDescriptor.type === 'group' &&
         descriptorId.match(/^publicChat:/) &&
         data.source === ourNumber
       ) {
-        // Remove public chat messages to ourselves
+        // Public chat messages from ourselves should be outgoing
-        return event.confirm();
+        message = await createSentMessage(data);
+      } else {
+        message = await createMessage(data);
       }
-      const message = await createMessage(data);
       const isDuplicate = await isMessageDuplicate(message);
       if (isDuplicate) {
         window.log.warn('Received duplicate message', message.idForLogging());
@@ -1396,10 +1398,10 @@
 
     return new Whisper.Message({
       source: textsecure.storage.user.getNumber(),
-      sourceDevice: data.device,
+      sourceDevice: data.sourceDevice,
       sent_at: data.timestamp,
       sent_to: sentTo,
-      received_at: now,
+      received_at: data.isPublic ? data.receivedAt : now,
       conversationId: data.destination,
       type: 'outgoing',
       sent: true,

js/models/conversations.js

@@ -1337,6 +1337,10 @@
 
         if (this.isPrivate()) {
           messageWithSchema.destination = destination;
+        } else if (this.isPublic()) {
+          // Public chats require this data to detect duplicates
+          messageWithSchema.source = textsecure.storage.user.getNumber();
+          messageWithSchema.sourceDevice = 1;
         }
         const attributes = {
           ...messageWithSchema,

js/models/messages.js

@@ -2020,7 +2020,10 @@
                 }
               );
             }
-          } else if (dataMessage.profile) {
+          } else if (
+            source !== textsecure.storage.user.getNumber() &&
+            dataMessage.profile
+          ) {
             ConversationController.getOrCreateAndWait(source, 'private').then(
               sender => {
                 sender.setLokiProfile(dataMessage.profile);