Merge pull request #1043 from neuroscr/fix-int-tests

make closed group create button clickable (via minimum height), onBlur calls onChange
pull/1046/head
Ryan Tharp 5 years ago committed by GitHub
commit 2e3ebc0c8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -206,9 +206,11 @@ function captureClicks(window) {
} }
const DEFAULT_WIDTH = 880; const DEFAULT_WIDTH = 880;
const DEFAULT_HEIGHT = 720; // add contact button needs to be visible (on HiDpi screens?)
// otherwise integration test fail
const DEFAULT_HEIGHT = 820;
const MIN_WIDTH = 880; const MIN_WIDTH = 880;
const MIN_HEIGHT = 720; const MIN_HEIGHT = 820;
const BOUNDS_BUFFER = 100; const BOUNDS_BUFFER = 100;
function isVisible(window, bounds) { function isVisible(window, bounds) {

@ -45,6 +45,7 @@ export class SessionIdEditable extends React.PureComponent<Props> {
spellCheck={false} spellCheck={false}
onKeyDown={this.handleKeyDown} onKeyDown={this.handleKeyDown}
onChange={this.handleChange} onChange={this.handleChange}
onBlur={this.handleChange}
value={value || text} value={value || text}
maxLength={maxLength} maxLength={maxLength}
/> />

@ -61,6 +61,10 @@ export class SessionInput extends React.PureComponent<Props, State> {
className={classNames( className={classNames(
enableShowHide ? 'session-input-floating-label-show-hide' : '' enableShowHide ? 'session-input-floating-label-show-hide' : ''
)} )}
// just incase onChange isn't triggered
onBlur={e => {
this.updateInputValue(e);
}}
onKeyPress={event => { onKeyPress={event => {
event.persist(); event.persist();
if (event.key === 'Enter' && this.props.onEnterPressed) { if (event.key === 'Enter' && this.props.onEnterPressed) {

Loading…
Cancel
Save