More refactoring to reduce global event dependencies

All Whisper.events listeners are now defined and bound in background.js,
and we no longer need global methods for opening the inbox and
conversation views, as those are handled by AppView or internally by
InboxView.

// FREEBIE

js/background.js

@@ -87,13 +87,14 @@
             appView.inboxView.networkStatusView.setSocketReconnectInterval(60000);
         });
 
-        [
+        Whisper.Notifications.on('click', function(conversation) {
-          'openInbox',
+            if (conversation) {
-          'openInstaller',
+                appView.openConversation(conversation);
-          'openConversation',
+            } else {
-          'openStandalone'
+                appView.openInbox({
-        ].forEach(function(eventName) {
+                    initialLoadComplete: initialLoadComplete
-          appView.listenTo(Whisper.events, eventName, appView[eventName]);
+                });
+            }
         });
     });
 

js/notifications.js

@@ -20,13 +20,12 @@
             this.on('remove', this.onRemove);
         },
         onclick: function() {
+            var conversation;
             var last = this.last();
-            if (!last) {
+            if (last) {
-                openInbox();
+                conversation = ConversationController.get(last.get('conversationId'));
-                return;
             }
-            var conversation = ConversationController.get(last.get('conversationId'));
+            this.trigger('click', conversation);
-            openConversation(conversation);
             this.clear();
         },
         update: function() {

js/panel_controller.js

@@ -25,10 +25,6 @@
     };
     var inboxWindowId = 'inbox';
 
-    window.openInbox = function(options) {
-        Whisper.events.trigger('openInbox', options);
-    };
-
     window.setUnreadCount = function(count) {
         if (count > 0) {
             window.setBadgeCount(count);
@@ -39,8 +35,4 @@
         }
     };
 
-    window.openConversation = function(conversation) {
-        Whisper.events.trigger('openConversation', conversation);
-    };
-
 })();

js/views/app_view.js

@@ -11,7 +11,6 @@
         events: {
             'click .openInstaller': 'openInstaller',
             'click .openStandalone': 'openStandalone',
-            'openInstaller': 'openInstaller',
             'openInbox': 'openInbox',
         },
         openView: function(view) {

js/views/network_status_view.js

@@ -25,12 +25,6 @@
             this.model = new Backbone.Model();
             this.listenTo(this.model, 'change', this.onChange);
         },
-        events: {
-            'click .openInstaller': 'openInstaller'
-        },
-        openInstaller: function() {
-            this.$el.trigger('openInstaller');
-        },
         onReconnectTimer: function() {
           this.setSocketReconnectInterval(60000);
         },