fix: review feedback

use isClosedGroup, update comment
pull/3066/head
William Grant 2 months ago
parent a3c80ad247
commit a139299cd1

@ -1739,10 +1739,10 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
return; return;
} }
const conversationId = this.id; const conversationId = this.id;
const isLegacyGroup = this.isGroup() && !this.isPublic() && this.id.startsWith('05'); const isLegacyGroup = this.isClosedGroup() && this.id.startsWith('05');
let friendRequestText; let friendRequestText;
// NOTE: legacy groups are never approved, so we don't should not cancel notifications // NOTE: legacy groups are never approved, so we should not cancel notifications
if (!this.isApproved() && !isLegacyGroup) { if (!this.isApproved() && !isLegacyGroup) {
window?.log?.info('notification cancelled for unapproved convo', this.idForLogging()); window?.log?.info('notification cancelled for unapproved convo', this.idForLogging());
const hadNoRequestsPrior = const hadNoRequestsPrior =

Loading…
Cancel
Save