Merge pull request #618 from sachaaaaa/simplify_bulk_edit_bar

Prevent instantiating a new BulkEdit react component with every click

js/views/bulk_edit_view.js

@@ -8,33 +8,29 @@
 
   Whisper.BulkEditView = Whisper.View.extend({
     initialize(options) {
-      this.selectedMessages = new Set();
+      this.memberView = null;
-      this.render();
+      this.props = {
-      this.onCancel = options.onCancel;
+        onCancel: options.onCancel,
-      this.onDelete = options.onDelete;
+        onDelete: options.onDelete,
+        messageCount: 0,
+      };
     },
     render() {
       if (this.memberView) {
-        this.memberView.remove();
+        this.memberView.update(this.props);
-        this.memberView = null;
+        return;
       }
-
       this.memberView = new Whisper.ReactWrapperView({
         className: 'bulk-edit-view',
         Component: window.Signal.Components.BulkEdit,
-        props: {
+        props: this.props,
-          messageCount: this.selectedMessages.size,
-          onCancel: this.onCancel,
-          onDelete: this.onDelete,
-        },
       });
 
       this.$el.append(this.memberView.el);
-      return this;
     },
 
-    update(selectedMessages) {
+    update(selectionSize) {
-      this.selectedMessages = selectedMessages;
+      this.props.messageCount = selectionSize;
       this.render();
     },
   });

js/views/conversation_view.js

@@ -1802,7 +1802,7 @@
         $('.compose').show();
       }
 
-      this.bulkEditView.update(this.model.selectedMessages);
+      this.bulkEditView.update(selectionSize);
     },
 
     resetMessageSelection() {