Clean up ahead of PR.

pull/1/head
Matthew Chen 7 years ago
parent b37588fc4c
commit bff6c84403

@ -134,7 +134,7 @@ class ContactViewController: OWSViewController, CNContactViewControllerDelegate
super.loadView() super.loadView()
self.view.preservesSuperviewLayoutMargins = false self.view.preservesSuperviewLayoutMargins = false
self.view.backgroundColor = UIColor(rgbHex: 0xefeff4) self.view.backgroundColor = heroBackgroundColor()
updateContent() updateContent()
@ -222,9 +222,6 @@ class ContactViewController: OWSViewController, CNContactViewControllerDelegate
let fieldsView = createFieldsView() let fieldsView = createFieldsView()
// See notes on how to use UIScrollView with iOS Auto Layout:
//
// https://developer.apple.com/library/content/releasenotes/General/RN-iOSSDK-6_0/
scrollView.addSubview(fieldsView) scrollView.addSubview(fieldsView)
fieldsView.autoPinLeadingToSuperviewMargin() fieldsView.autoPinLeadingToSuperviewMargin()
fieldsView.autoPinTrailingToSuperviewMargin() fieldsView.autoPinTrailingToSuperviewMargin()
@ -232,11 +229,15 @@ class ContactViewController: OWSViewController, CNContactViewControllerDelegate
fieldsView.autoPinEdge(toSuperviewEdge: .bottom) fieldsView.autoPinEdge(toSuperviewEdge: .bottom)
} }
private func heroBackgroundColor() -> UIColor {
return UIColor(rgbHex: 0xefeff4)
}
private func createTopView() -> UIView { private func createTopView() -> UIView {
SwiftAssertIsOnMainThread(#function) SwiftAssertIsOnMainThread(#function)
let topView = UIView.container() let topView = UIView.container()
topView.backgroundColor = UIColor(rgbHex: 0xefeff4) topView.backgroundColor = heroBackgroundColor()
topView.preservesSuperviewLayoutMargins = false topView.preservesSuperviewLayoutMargins = false
// Back Button // Back Button
@ -422,8 +423,7 @@ class ContactViewController: OWSViewController, CNContactViewControllerDelegate
// } // }
for phoneNumber in contact.phoneNumbers { for phoneNumber in contact.phoneNumbers {
let formattedPhoneNumber = let formattedPhoneNumber = PhoneNumber.bestEffortFormatE164(asLocalizedPhoneNumber: phoneNumber.phoneNumber)
PhoneNumber.bestEffortFormatE164(asLocalizedPhoneNumber: phoneNumber.phoneNumber)
addRow(createNameValueRow(name: phoneNumber.localizedLabel(), addRow(createNameValueRow(name: phoneNumber.localizedLabel(),
value: formattedPhoneNumber, value: formattedPhoneNumber,

@ -285,10 +285,6 @@ NSString *const kArchivedConversationsReuseIdentifier = @"kArchivedConversations
} }
[self updateBarButtonItems]; [self updateBarButtonItems];
dispatch_async(dispatch_get_main_queue(), ^{
[self tableView:self.tableView didSelectRowAtIndexPath:[NSIndexPath indexPathForRow:0 inSection:0]];
});
} }
- (void)applyDefaultBackButton - (void)applyDefaultBackButton

Loading…
Cancel
Save