Fix call timeout

- Previously only incoming calls had their timeout promise fulfilled
- Previously we'd stop the timeout once ringing started, but we
should continue the timeout clock until the users are speaking.

// FREEBIE

Signal/src/call/CallService.swift

@@ -322,6 +322,8 @@ protocol CallServiceObserver: class {
             }
 
             return race(timeout, callConnectedPromise)
+        }.then {
+            Logger.info("\(self.TAG) outgoing call connected.")
         }.catch { error in
             Logger.error("\(self.TAG) placing call failed with error: \(error)")
 
@@ -501,6 +503,8 @@ protocol CallServiceObserver: class {
             self.fulfillCallConnectedPromise = fulfill
 
             return race(promise, timeout)
+        }.then {
+            Logger.info("\(self.TAG) incoming call connected.")
         }.catch { error in
             guard self.call == newCall else {
                 Logger.debug("\(self.TAG) error for obsolete call: \(error)")
@@ -617,8 +621,6 @@ protocol CallServiceObserver: class {
         case .answering:
             call.state = .localRinging
             self.callUIAdapter.reportIncomingCall(call, thread: thread)
-            // cancel connection timeout
-            self.fulfillCallConnectedPromise?()
         case .remoteRinging:
             Logger.info("\(TAG) call alreading ringing. Ignoring \(#function)")
         case .connected:
@@ -735,6 +737,10 @@ protocol CallServiceObserver: class {
             return
         }
 
+        assert(self.fulfillCallConnectedPromise != nil)
+        // cancel connection timeout
+        self.fulfillCallConnectedPromise?()
+
         call.state = .connected
 
         // We don't risk transmitting any media until the remote client has admitted to being connected.

Signal/src/call/Speakerbox/CallKitCallUIAdaptee.swift

@@ -84,7 +84,13 @@ final class CallKitCallUIAdaptee: NSObject, CallUIAdaptee, CXProviderDelegate {
         AssertIsOnMainThread()
         Logger.debug("\(self.TAG) \(#function)")
 
+        switch (error) {
+        case .timeout(description: _):
+            provider.reportCall(with: call.localId, endedAt: Date(), reason: CXCallEndedReason.unanswered)
+        default:
             provider.reportCall(with: call.localId, endedAt: Date(), reason: CXCallEndedReason.failed)
+        }
+
         self.callManager.removeCall(call)
     }