Commit Graph

1119 Commits (6f64a809f341c2b1da420ea887d1467370619bed)

Author SHA1 Message Date
Matthew Chen 37ae4ef360 Add typing indicator animation. 7 years ago
Matthew Chen 63d88ef5cb Sketch out TypingIndicatorCell. 7 years ago
Matthew Chen eedc9f9a26 Sketch out "typing indicators" interaction and cell. 7 years ago
Michael Kirk 77bd9b8852 Extract most Gallery functionality from the gallery NavigationController.
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.

The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
7 years ago
Matthew Chen 834bba8880 Respond to CR. 7 years ago
Matthew Chen 32d3eed7ba Add ConversationViewModel. 7 years ago
Matthew Chen 3d0e7386a4 Respond to CR. 7 years ago
Matthew Chen a98c82645c Start work on typing indicators.
* Update proto schema to reflect typing indicators.
* Sketch out OWSTypingIndicatorMessage.
* Add "online" to the service message params.
* Sketch out logic to send typing indicator messages.
* Sketch out OWSTypingIndicators class.
7 years ago
Matthew Chen 40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Michael Kirk 3d9cd4f4ed CR: comments and code clarity 7 years ago
Michael Kirk cb9aa6304c find -E . -type f -regex ".*\.(m|h)" -exec sed -i "" -e "s/try_/throws_/" {} \; 7 years ago
Michael Kirk 3a6aafc454 Swift Exception wrap NSData+keyVersionByte 7 years ago
Michael Kirk 3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
7 years ago
Michael Kirk e20df022c8 always show footer for in-progress sending 7 years ago
Michael Kirk ce9ca1bdaa audio player type 7 years ago
Michael Kirk 3b4188f34b hoist audio session singleton to Environment 7 years ago
Michael Kirk 3d022adf4e WIP: audio activities 7 years ago
Matthew Chen 0b4ed1175d Create AppEnvironment. 7 years ago
Matthew Chen f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 7 years ago
Matthew Chen 0b41e5e240 Rework profile fetch to reflect UD changes. 7 years ago
Michael Kirk f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
7 years ago
Michael Kirk 006021ea41 Fix: group color change doesn't immediately apply
Because we were fetching a new thread instance, instead of updating the
existing thread instance, classes which were bound to the old thread instance
weren't updating. This affected the HeaderView.AvatarView.thread and the
ConversationStyle.thread.
7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Michael Kirk 06eae47e09 ConversationViewItem -> protocol 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
7 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 7 years ago
Matthew Chen 1c1d305a71 Respond to CR. 7 years ago
Matthew Chen cbaf40d4ce Respond to CR. 7 years ago
Matthew Chen d161e5ff3d Add inner shadows to media thumbnails. 7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Michael Kirk c21020d7e7 Use received date for footer-collapse supression 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
7 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
7 years ago
Michael Kirk 90aa593dcd sortId vs. Read status 7 years ago
Michael Kirk d6d6c4fca4 ConversationVC - lastSeenSortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Matthew Chen 72562920ed Fix author conversation colors. 7 years ago
Matthew Chen 4186ce9a72 Respond to CR. 7 years ago
Matthew Chen 7b2dd19fb8 Respond to CR. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Matthew Chen b30bfec21f Fix contact offer button margins. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk 2eca462efc can view conversation settings for left group 7 years ago
Michael Kirk b1da5e93d9 group blocking v. conversation view 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen dc3467dcda Tidy up attachment usage. 7 years ago
Matthew Chen 30ed6caf06 Use thumbnails as video stills in conversation view. 7 years ago
Matthew Chen ad0d094831 Fix build breakage. 7 years ago
Matthew Chen 748b243156 Restore full-screen thumbnails. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen cf469da943 Use new thumbnails in conversation cells. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Michael Kirk 5d9cd86d13 size toolbar WRT draft 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk 2cdca0299c show generic file icon for invalid GIF 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen 1cc0fbcb12 Elaborate logging around 'perform updates' crash. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen b3c19b7905 Improve logging of conversation view exceptions. 7 years ago
Michael Kirk a1e8bb865c Larger jumbomoji 7 years ago