Commit Graph

1119 Commits (6f64a809f341c2b1da420ea887d1467370619bed)

Author SHA1 Message Date
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk 2eca462efc can view conversation settings for left group 7 years ago
Michael Kirk b1da5e93d9 group blocking v. conversation view 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen dc3467dcda Tidy up attachment usage. 7 years ago
Matthew Chen 30ed6caf06 Use thumbnails as video stills in conversation view. 7 years ago
Matthew Chen ad0d094831 Fix build breakage. 7 years ago
Matthew Chen 748b243156 Restore full-screen thumbnails. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen cf469da943 Use new thumbnails in conversation cells. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Michael Kirk 5d9cd86d13 size toolbar WRT draft 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk 2cdca0299c show generic file icon for invalid GIF 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen 1cc0fbcb12 Elaborate logging around 'perform updates' crash. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen b3c19b7905 Improve logging of conversation view exceptions. 7 years ago
Michael Kirk a1e8bb865c Larger jumbomoji 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 4096d2e0d8 Respond to CR. 7 years ago
Matthew Chen 2fecb270e6 Cache footer timestamp size. 7 years ago
Matthew Chen c91bc71ebd Cache sender name size. 7 years ago
Matthew Chen dd7e429318 Skip default implementation of preferredLayoutAttributesFittingAttributes. 7 years ago
Matthew Chen 0ac1cb1e72 Cache system message text. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen 069c66e5e8 Refine theme. 7 years ago
Matthew Chen b3c62d91be Merge remote-tracking branch 'origin/release/2.28.1' 7 years ago
Matthew Chen 7cc8674201 Fix "save non-media attachment" crash. 7 years ago
Michael Kirk 51b1761364 Fix crash during CollectionView thrash 7 years ago
Michael Kirk 7e5d9480b1 Add missing header file 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk e5b3cbd00c Use StoreKit for reviews 7 years ago
Matthew Chen faf3cd6a55 Fix lazy collapse of message cell footers. 7 years ago
Matthew Chen cea93784b1 Avoid redundant content inset updates. 7 years ago
Matthew Chen 9b45a15c35 Merge branch 'release/2.28.1' 7 years ago
Matthew Chen 4918b8994e Delay footer collapse in new messages. 7 years ago
Matthew Chen 95cf4f5c6d Don't reserve space for timestamp in footer. 7 years ago
Matthew Chen 251eef46a2 Delay footer collapse in new messages. 7 years ago
Matthew Chen 4d2bdf9bd0 Respond to CR. 7 years ago
Matthew Chen 21c630c095 Ignore redundant body text view updates; cache body text view size. 7 years ago
Matthew Chen dfc39b4a1d Tidy files. 7 years ago
Matthew Chen e6bc37d941 Tidy files. 7 years ago
Matthew Chen 2c19474397 Tidy files. 7 years ago
Matthew Chen 8f55f53329 Tidy files. 7 years ago
Michael Kirk 103a8dc579 ubsan fixups 7 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 7 years ago
Matthew Chen cd6225c438 Respond to CR. 7 years ago
Matthew Chen 995c2f2a2a Refine 'new message' animations. 7 years ago
Matthew Chen 24d85898e1 Refine 'new message' animations. 7 years ago
Matthew Chen 026ef02ce5 Refine 'new message' animations. 7 years ago
Jesse Squires 6dc74ddcaf Fix some project warnings + other fixes
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
7 years ago
Matthew Chen 1b01e8f65f Clean up timer animation. 7 years ago
Matthew Chen baf432f1ee Respond to CR. 7 years ago
Matthew Chen fa8a07abf1 Respond to CR. 7 years ago
Matthew Chen 7759c9ca0f Refine theme. 7 years ago
Michael Kirk 6e1c1a681b Merge tag '2.28.0.12' 7 years ago
Michael Kirk 2d4eb7d057 remove interactive 'swipe for info' 7 years ago
Michael Kirk 551bb5b93b ubsan fixup 7 years ago
Matthew Chen 88c5fc1af8 Fix message footer alignment. 7 years ago
Matthew Chen e271730f33 Ignore gestures in date breaks and unread indicators. 7 years ago
Matthew Chen 9d5af7bb2e Set sender names apart. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Michael Kirk 9e348f2a27 update ubsan 7 years ago
Matthew Chen d14f764b50 Streamline SignalRecipient. 7 years ago
Michael Kirk ef9a0880ae Fix analyzer warnings 7 years ago
Michael Kirk baacebc956 Enable (quick) static analyzer for normal builds
// FREEBIE
7 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 7 years ago
Michael Kirk 2b5db4fd1a Add header view to info messages.
I considered extracting this from OWSMessageCell and putting it into
ConversationCell, but that would be a pretty large change.

// FREEBIE
7 years ago
Michael Kirk 17e79a522a fixup audio/generic atachment margins 7 years ago
Michael Kirk c2063d8600 replace bullet with center-dot unicode
// FREEBIE
7 years ago
Michael Kirk 567f625902 touch instead of reload to make sure any adjacent bubbles are updated appropriately. 7 years ago
Michael Kirk 2c3f7db4e4 Only add one 'incoming message' unread indicator per foreground.
// FREEBIE
7 years ago
Michael Kirk f2f3b9eaed reload cell after removing unread indicator
// FREEBIE
7 years ago
Michael Kirk 1b78882660 per design: tweak quote corner radius
// FREEBIE
7 years ago
Matthew Chen e3622739b2 Remove media thumbnail shadows. 7 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 7 years ago
Michael Kirk f33e5c019c CR: assign gutter trailing/leading in HeaderView
// FREEBIE
7 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
7 years ago
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
7 years ago
Michael Kirk 0847c0bafb ScrollToBottom accounts for top inset
// FREEBIE
7 years ago
Matthew Chen 687efabede Respond to CR. 7 years ago
Matthew Chen 96a8df5f88 Fix "new unread indicator animation" issue. 7 years ago
Matthew Chen f69945ea20 Fix 'breaks vs. collapse' issue. 7 years ago
Michael Kirk 39bbcca738 CR: cleanup / copy tweak 7 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
7 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
7 years ago
Michael Kirk 41c1c2fcd5 scroll focused view to maximize visability
// FREEBIE
7 years ago
Michael Kirk ce3030917f MessageActions for info messages 7 years ago
Michael Kirk 42eb7a8d31 cleanup unused code 7 years ago
Michael Kirk 210cba3e37 Media actions 7 years ago
Michael Kirk 729336774c delete text 7 years ago
Michael Kirk 2552368146 add text reply action, comment out more deprecated uimenu code 7 years ago
Michael Kirk 6079ae2439 show text details, dismiss before action to avoid problems when action presents 7 years ago
Michael Kirk 5c2a5b00aa comment 7 years ago
Michael Kirk 0c4cae133b milestone: route one real action (copy text) 7 years ago
Michael Kirk 57400e1ecb WIP: ActionView 7 years ago
Michael Kirk 18adf26e06 Don't present over navbar.
// FREEBIE
7 years ago
Michael Kirk 635c0275db stop observing db notifications while message actions are presented
This let's new messages appear after the message actions are dismissed without
complicating scroll state.
7 years ago
Michael Kirk 6275a2f102 Highlight focused view 7 years ago
Michael Kirk ea179a398b first responder debugging 7 years ago
Michael Kirk aa98963fd9 Abandonded: separate window pattern
Hiding the old window, caused keyboard to resign first responder.
7 years ago
Michael Kirk 6037a440c9 wire up window mgmt 7 years ago
Michael Kirk a2c67bb96b Enhance navbar blur, match input toolbar blur
// FREEBIE
7 years ago
Matthew Chen 246218e333 Apply 'disappearing messages disabled' icon. 7 years ago
Matthew Chen 4d3707a16e Apply "disappearing messages disabled" icon. 7 years ago
Matthew Chen 8287076499 More design tweaks. 7 years ago
Matthew Chen 49b0ea993d Dedupe forward class declarations. 7 years ago
Matthew Chen a505c2a89e Tweak unread indicator + date. 7 years ago
Matthew Chen 376e2cc1db Respond to CR. 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen e48a1e0816 Respond to CR. 7 years ago
Matthew Chen 6711ed1cf3 Respond to CR. 7 years ago
Matthew Chen f426af8167 Respond to CR. 7 years ago
Matthew Chen 6d45d533ef Respond to CR. 7 years ago
Matthew Chen e01579ed44 Tweak disappearing messages indicator. 7 years ago